Skip to content

Fix additional Ruff issues#394

Merged
brianhelba merged 10 commits intomainfrom
ruff-fixes
Mar 2, 2026
Merged

Fix additional Ruff issues#394
brianhelba merged 10 commits intomainfrom
ruff-fixes

Conversation

@brianhelba
Copy link
Member

A few of these are slightly bigger refactors, so the easiest way to review is probably commit-by-commit.

@brianhelba
Copy link
Member Author

@BryonLewis @BryonLewis FYI, regarding boolean-type-hint-positional-argument, the essence of the rule is that positional boolean parameters are risky, but keyword boolean parameters are fine. Generally, the easiest way to resolve this is to just put the boolean behind a keyword-only syntax (e.g. def foo(*, bool_flag).

On the calling side, for boolean-positional-value-in-call, note that most of BatAI is already doing a great job with using a keyword syntax when passing boolean arguments, so very little change was needed.

Copy link
Collaborator

@BryonLewis BryonLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for organizing this by commit.
I went through and everything seemed clear to me.

Also, thanks for cleaning up my inconsistent casing. Jumping between Vue and Django can get me tripped up with camelCase vs. snake_case. I’ll keep a closer eye on that (the ruff rules not being blocked should force me to now).

@brianhelba
Copy link
Member Author

Indeed, no need to think about such minor style stuff anymore. Ruff's your backstop.

@brianhelba brianhelba merged commit 2123345 into main Mar 2, 2026
6 checks passed
@brianhelba brianhelba deleted the ruff-fixes branch March 2, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants