fix: fix race condition for default engine init#273
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Addresses #249 by making default engine selection safer under concurrent first access in Engine’s companion, reducing the chance of inconsistent/overwritten initialization across threads.
Changes:
- Marked
defaultEngineas@Volatileand added double-check logic inloadEngine(). - Updated
getDefaultEngine()to avoid expression-based initialization and use a local cached read. - Updated
getMath()/getLinAlg()/getStatistics()to use a local engine snapshot and trigger lazy init when needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #249
Checklist