-
Notifications
You must be signed in to change notification settings - Fork 5
CI Update #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Update #369
Conversation
|
Ok I see this isn't the only problem. I'll have a look a bit later. |
|
I think its mainly outdated Python 3.8 is EOL and thus no longer available, same for some compilers |
Yep, so I think it's up to you what you want to support specifically. Should I update the CI to some versions I find useful, or will you handle the updates yourself? |
|
I would appreciate if you could do it |
…ou won't complain if I don't use them, right? - Oh you bet I will.
|
EDIT: Nevermind, I moved a line I shouldn't have by mistake. |
|
Apart from setting up Rocky Linux this PR is ready for review, take a peek please. ChangelogCI
Tests and Examples
|
philbucher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work, thanks a lot
minor comments
This reverts commit 9420d94.
|
@philbucher this PR is ready for review. Can you please take a look at the MacOS runs? It failed twice on the same parent test case but on different subcases, then passed on the third try. I doubt it had anything to do with this PR. |
|
awesome, thanks for the work Regarding Mac, seems that the local-sockets comm fails sometimes. Its been a while, but last time I was working on it, this feature was still a bit under development and perhaps not fully stable. |
Trying to resolve CI failure in #368.
upload-artifactv1throughv3are deprecated, so I updated it tov4.