[pull] main from NVIDIA:main#1038
Merged
pull[bot] merged 4 commits intoLarryXFly:mainfrom Mar 12, 2026
Merged
Conversation
…server (#11992) Five fixes for the gRPC server: 1. Use context.abort() for errors (grpc_servicer.py): Replace in-band GenerateError responses with proper context.abort() calls for input validation and internal errors, matching standard gRPC error handling conventions. 2. Add unit tests (test_grpc.py). 3. Add keepalive ping tolerance (serve.py). Without these, the default 300s ping tolerance causes the server to send GOAWAY with ENHANCE_YOUR_CALM when clients (e.g. sgl-router) send keepalive pings every 30s on idle connections. 4. Fix wrong field names in create_disaggregated_params_from_proto (grpc_request_manager.py) that led to runtime crashes. 5. Use context.abort() in Embed RPC (grpc_servicer.py) for consistency with the rest of the servicer. Signed-off-by: Chang Su <chang.s.su@oracle.com> Signed-off-by: Chang Su <changsu@nvidia.com> Co-authored-by: William Zhang <133824995+2ez4bz@users.noreply.github.com>
…12053) Signed-off-by: Iman Tabrizian <10105175+tabrizian@users.noreply.github.com>
…12086) Signed-off-by: Derek Pitman <dpitman@nvidia.com> Signed-off-by: dpitman-nvda <dpitman@nvidia.com> Co-authored-by: tburt-nv <195370667+tburt-nv@users.noreply.github.com>
#12156) Signed-off-by: Tal Cherckez <127761168+tcherckez-nvidia@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )