-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Sanitize profile filename #21395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SkafteNicki
wants to merge
6
commits into
Lightning-AI:master
Choose a base branch
from
SkafteNicki:sanitize_profile_filename
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Sanitize profile filename #21395
SkafteNicki
wants to merge
6
commits into
Lightning-AI:master
from
SkafteNicki:sanitize_profile_filename
+39
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21395 +/- ##
=========================================
- Coverage 86% 79% -8%
=========================================
Files 269 266 -3
Lines 23809 23761 -48
=========================================
- Hits 20574 18657 -1917
- Misses 3235 5104 +1869 |
bhimrazy
approved these changes
Dec 9, 2025
justusschock
approved these changes
Dec 10, 2025
deependujha
reviewed
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #21365
Make sure that filenames are sanitized when profiler is trying to dump
.proffiles.This will currently crash if there are characters such as "/" in the filename, which happens if the user has a
ModelCheckpointwith a monitoring metric like"val/acc".Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21395.org.readthedocs.build/en/21395/