Skip to content

Conversation

@GdoongMathew
Copy link
Contributor

@GdoongMathew GdoongMathew commented Dec 13, 2025

What does this PR do?

Fixes #21412

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21413.org.readthedocs.build/en/21413/

@github-actions github-actions bot added pl Generic label for PyTorch Lightning package dependencies Pull requests that update a dependency file labels Dec 13, 2025
@codecov
Copy link

codecov bot commented Dec 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79%. Comparing base (9ae18f7) to head (f67cbe1).
✅ All tests successful. No failed tests found.

❗ There is a different number of reports uploaded between BASE (9ae18f7) and HEAD (f67cbe1). Click for more details.

HEAD has 1146 uploads less than BASE
Flag BASE (9ae18f7) HEAD (f67cbe1)
python3.12.7 80 9
lightning_fabric 74 0
pytest 149 0
cpu 289 30
python3.12 89 9
python3.10 30 3
lightning 140 15
python3.11 60 6
python 30 3
pytorch_lightning 75 15
pytorch2.7 15 3
pytest-full 140 30
pytorch2.1 30 6
pytorch2.2.2 15 3
pytorch2.6 15 3
pytorch2.3 15 3
pytorch2.8 15 3
pytorch2.4.1 10 3
pytorch2.9 15 3
pytorch2.5.1 10 3
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #21413     +/-   ##
=========================================
- Coverage      86%      79%     -8%     
=========================================
  Files         269      266      -3     
  Lines       23809    23754     -55     
=========================================
- Hits        20574    18719   -1855     
- Misses       3235     5035   +1800     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file pl Generic label for PyTorch Lightning package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] Missing torch-tensorrt during CI testing

1 participant