fix: make upload path mandatory - #57
Merged
Merged
Conversation
lianakoleva
requested review from
ethanwharris,
justusschock and
k223kim
as code owners
July 29, 2026 00:30
Member
|
if it's mandatory, it should be a positional argument. flags are meant to be optional (hence the name |
dwnetautomation
approved these changes
Jul 29, 2026
rusenask
approved these changes
Jul 30, 2026
tejapulagam
approved these changes
Jul 31, 2026
tejapulagam
enabled auto-merge (squash)
July 31, 2026 05:34
tejapulagam
disabled auto-merge
July 31, 2026 05:34
justusschock
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before
running
seems to imply i need to supply
lightning model upload <filename/dirname>, when in reality if i do that, it begins to upload my entire current directory. theNAMEit expects isORG-NAME/TEAMSPACE-NAME/MODEL-NAMEwith optional--path, defaulting to current directory (.).after
upload path is mandatory, rather than defaulting to current directory (
.)and help message is much more helpful