Skip to content

fix: make upload path mandatory - #57

Merged
justusschock merged 5 commits into
mainfrom
lk/upload-path-mandatory
Jul 31, 2026
Merged

fix: make upload path mandatory#57
justusschock merged 5 commits into
mainfrom
lk/upload-path-mandatory

Conversation

@lianakoleva

Copy link
Copy Markdown
Contributor

before

running

> lightning model upload

 ⚡  Lightning AI  The training and experimentation cloud.

 Usage: lightning model upload [OPTIONS] NAME

Try 'lightning model upload --help' for help.

Error: Missing argument 'NAME'.

seems to imply i need to supply lightning model upload <filename/dirname>, when in reality if i do that, it begins to upload my entire current directory. the NAME it expects is ORG-NAME/TEAMSPACE-NAME/MODEL-NAME with optional --path, defaulting to current directory (.).

after

upload path is mandatory, rather than defaulting to current directory (.)

> lightning model upload model-dir

 ⚡  Lightning AI  The training and experimentation cloud.

 Usage: lightning model upload [OPTIONS] ORG-NAME/TEAMSPACE-NAME/MODEL-NAME

Try 'lightning model upload --help' for help.

Error: Missing option '--path'.

and help message is much more helpful

> lightning model upload

 ⚡  Lightning AI  The training and experimentation cloud.

 Usage: lightning model upload [OPTIONS] ORG-NAME/TEAMSPACE-NAME/MODEL-NAME

Try 'lightning model upload --help' for help.

Error: Missing argument 'ORG-NAME/TEAMSPACE-NAME/MODEL-NAME'.

@justusschock

Copy link
Copy Markdown
Member

if it's mandatory, it should be a positional argument. flags are meant to be optional (hence the name click.option :) )

@tejapulagam
tejapulagam enabled auto-merge (squash) July 31, 2026 05:34
@tejapulagam
tejapulagam disabled auto-merge July 31, 2026 05:34
@justusschock
justusschock merged commit 82a0daa into main Jul 31, 2026
24 checks passed
@justusschock
justusschock deleted the lk/upload-path-mandatory branch July 31, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants