feat: unify jobs + mmt under jobs command - #68
Draft
tejapulagam wants to merge 1 commit into
Draft
Conversation
tejapulagam
requested review from
ethanwharris,
justusschock and
k223kim
as code owners
July 30, 2026 22:21
tejapulagam
marked this pull request as draft
July 30, 2026 22:27
Member
|
This should match with the SDK though, so we'd need to merge both classes as well (which would be doable). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lightning jobso one CLI covers single- and multi-machine jobs.job run --num-machines N(default1) creates an MMT whenN > 1.job listincludes both Jobs and MMTs (num_machinescolumn).job inspect/logs/sshaccept--rankfor MMT workers.job stop/deleteresolve Job or MMT and act on the whole resource (no per-rank stop/delete).resource_resolution(resolve_job_or_mmt,resolve_mmt_machine).lightning mmtleft in place for now (deprecation later).Test plan
job runwith default--num-machines 1still creates a Jobjob run --num-machines 2creates an MMTjob listshows Jobs and MMTs with correctnum_machinesjob inspect/logs/sshwork for Jobs; with--rankfor MMT workersjob stop/deletestop/delete an entire MMT (not a single rank)lightning mmtcommands still workpython/tests/cli/job/+test_resource_resolution.py