[WIP] Drop the need for exporting TCLLIBPATH, use system path [v2]#4140
Draft
NTULINUX wants to merge 2 commits into
Draft
[WIP] Drop the need for exporting TCLLIBPATH, use system path [v2]#4140NTULINUX wants to merge 2 commits into
NTULINUX wants to merge 2 commits into
Conversation
Contributor
Author
|
@BsAtHome do you have any recommendations on fixing linuxcnc.install.in so it uses What about something like: There's also this hard-code too in rules.in: Trying something... |
Contributor
Author
|
Uh oh.. build failed:
Adding |
Signed-off-by: Alec Ari <neotheuser@ymail.com>
Signed-off-by: Alec Ari <neotheuser@ymail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know how to restore my last PR properly with the fixed tree so making a new one.
This avoids hard-coding LinuxCNC to use a path outside of the system's default Tcl search path, making it no longer required to specify TCLLIBPATH on Gentoo and Fedora. Logging in and out in order to update the environmental variables so the icons/menu entries work is also no longer needed.