Orient.comp: Add modes with preceding homing to index - #4343
Conversation
4f75431 to
56a499e
Compare
56a499e to
ddadd47
Compare
|
Thank you for reviewing and your pointers! Much appreciated. |
|
You are welcome. I'm just looking at this on the structural level. Not looking at what it is actually doing ;-) There may be one more problem. You have a message printing when the mode value is not handled. If I'm not mistaking, this message would print at every thread-cycle flooding the terminal and GUI. |
grandixximo
left a comment
grandixximo
left a comment
There was a problem hiding this comment.
Thanks for the patch. Tested-on-hardware confirmation is much appreciated, and the state machine structure is a clean way to add the index modes. I have a few questions and concerns inline, mostly around behavior changes in the existing modes.
ddadd47 to
dd9e02d
Compare
|
Thanks again for investing the time to review! |
orient.comp currently does not support using an index signal. This makes it unusable for setups where the spindle encoder position cannot be tracked due to the encoder reading being too slow.
234e155 to
cc32ccf
Compare
|
Changed 'M19' doc: |
|
The way I had anticipated solving this was to add spindle homing pins to the spindle control logic. It is almost certainly simpler to add it to the orient comp, but I am not sure which way is better. |
Something against having both? |
4 participants
Some spindle encoder setups cannot track the encoder position when using high spindle speeds and thus cannot use the current 'orient' component due to lost encoder position.
This PR expands the orient component with three additional modes that offer referencing to an index signal prior to orienting the spindle.
Current behavior is unchanged. All modes have been tested on real hardware.
Based on work by @andypugh
For more:
https://forum.linuxcnc.org/10-advanced-configuration/42792-m19-and-spindle-index-enable-issues?start=10