Repository navigation
Conversation
markuslf
self-requested a review
June 25, 2024 06:02
…zernIO/lib into support_avelon_cloud_api
markuslf
added a commit
to Linuxfabrik/monitoring-plugins
that referenced
this pull request
Sep 18, 2026
Reimplements #771 and Linuxfabrik/lib#84 along our current standards, keeping their logic and their fixtures. - Uses /public-api/v2/tickets; v1 is gone from the OpenAPI document. - Asks per device (filterScope DEVICE), since DeviceTO no longer carries a clientId, and in parallel. - Requests unclosed tickets back to 2000-01-01: without beginDate the API returns only tickets modified within seven days, so an untouched open alarm would drop out after a week (from the docs, not measured). - Covers all nine ticket statuses and three ticket types. - Keeps the Avelon access in the plugin, as it has a single consumer.
Member
|
Thank you. The Avelon access now lives in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Avelon library was created to communicate with the Avelon Cloud API. It provides three public functions: get_token, get_ticket, and get_data_points. The get_token and get_ticket functions should be fully complete. However, the get_data_points function still lacks detailed error handling. This will be addressed with the upcoming Avelon_XY (data_points) monitoring plugin. Despite this, functional tests have been conducted across all functions.