Skip to content

fix(windows/installer): PATH update reg add /f option ordering #5584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReenigneArcher merged 1 commit into from
Aug 30, 2026
+5 −3
Merged

fix(windows/installer): PATH update reg add /f option ordering #5584

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src_assets/windows/misc/path/update-path.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,9 @@ if /i "%~1"=="add" (
rem Only update if path was changed
if "!NEW_PATH!" neq "!CURRENT_PATH!" (
rem Set the new path in the registry
reg add "%KEY_NAME%" /v "%VALUE_NAME%" /t REG_EXPAND_SZ /d "!NEW_PATH!" /f
rem Some localized systems may unexpectedly ignore /f at the end of the command.
rem Keep it before /d so the installer never waits for overwrite confirmation.
reg add "%KEY_NAME%" /v "%VALUE_NAME%" /t REG_EXPAND_SZ /f /d "!NEW_PATH!"
if !ERRORLEVEL!==0 (
echo Successfully added Sunshine directories to PATH
) else (
Expand Down Expand Up @@ -94,8 +96,8 @@ if /i "%~1"=="remove" (
rem Only update if path was changed
if "!CHANGES_MADE!"=="1" (
rem Set the new path in the registry
rem Windows systems running Chinese may unexpectedly ignore the /f option at the end of the command.
rem This issue only occurs with the remove command.
rem Some localized systems may unexpectedly ignore /f at the end of the command.
rem Keep it before /d so the installer never waits for overwrite confirmation.
reg add "%KEY_NAME%" /v "%VALUE_NAME%" /t REG_EXPAND_SZ /f /d "!CURRENT_PATH!"
if !ERRORLEVEL!==0 (
echo Successfully removed Sunshine directories from PATH
Expand Down
Loading