fix: handle exceptions explicitly in destructors#251
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #251 +/- ##
==========================================
- Coverage 93.01% 92.87% -0.14%
==========================================
Files 35 35
Lines 2275 2289 +14
Branches 1120 1126 +6
==========================================
+ Hits 2116 2126 +10
- Misses 42 60 +18
+ Partials 117 103 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
|
Add explicit exception handling and reporting for destructor cleanup paths. Introduce <exception> includes and helper functions (reportLogWriterException, reportSchedulerStopTokenException) that write std::exception::what() to stderr. Replace catch(...) with catch(const std::exception&) in LogWriter and SchedulerStopToken destructors and call the new report helpers so destructors remain noexcept but provide diagnostic output. Update unit tests to define and throw custom std::exception-derived test exceptions and add needed includes.
|
ReenigneArcher
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes sonar cpp:S1048.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage