Skip to content

refactor(sonar): fix cpp:S6004#256

Merged
ReenigneArcher merged 1 commit into
masterfrom
refactor/sonar/fix-cpp-S6004
Jun 9, 2026
Merged

refactor(sonar): fix cpp:S6004#256
ReenigneArcher merged 1 commit into
masterfrom
refactor/sonar/fix-cpp-S6004

refactor(sonar): fix cpp:S6004

2f03169
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 9, 2026 in 1s

92.79% (-0.01%) compared to 1f0305f

View this Pull Request on Codecov

92.79% (-0.01%) compared to 1f0305f

Details

Codecov Report

❌ Patch coverage is 81.48148% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.79%. Comparing base (1f0305f) to head (2f03169).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/windows/win_api_layer.cpp 33.33% 0 Missing and 4 partials ⚠️
src/common/logging.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
- Coverage   92.79%   92.79%   -0.01%     
==========================================
  Files          35       35              
  Lines        2291     2275      -16     
  Branches     1131     1116      -15     
==========================================
- Hits         2126     2111      -15     
- Misses         42       68      +26     
+ Partials      123       96      -27     
Files with missing lines Coverage Δ
src/common/types.cpp 100.00% <100.00%> (+1.88%) ⬆️
src/windows/settings_manager_apply.cpp 98.73% <100.00%> (ø)
src/windows/settings_utils.cpp 95.61% <100.00%> (-0.02%) ⬇️
src/windows/win_api_utils.cpp 99.58% <100.00%> (-0.01%) ⬇️
src/windows/win_display_device_hdr.cpp 98.59% <100.00%> (ø)
src/windows/win_display_device_modes.cpp 99.13% <100.00%> (-0.02%) ⬇️
src/windows/win_display_device_primary.cpp 100.00% <100.00%> (ø)
src/windows/win_display_device_topology.cpp 97.95% <100.00%> (-0.03%) ⬇️
src/common/logging.cpp 93.15% <0.00%> (-0.10%) ⬇️
src/windows/win_api_layer.cpp 75.71% <33.33%> (-0.35%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f0305f...2f03169. Read the comment docs.