-
Notifications
You must be signed in to change notification settings - Fork 32
GH-623: Direct Node to pick new public key on the command line #679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dnwiebe
wants to merge
47
commits into
master
Choose a base branch
from
GH-623
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnwiebe
commented
Aug 3, 2025
dnwiebe
commented
Aug 3, 2025
dnwiebe
commented
Aug 3, 2025
dnwiebe
commented
Aug 3, 2025
dnwiebe
commented
Aug 3, 2025
dnwiebe
commented
Aug 3, 2025
dnwiebe
commented
Aug 3, 2025
dnwiebe
commented
Aug 3, 2025
czarte
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches startup configuration and persistent key selection logic; incorrect handling could cause nodes to fail to start or unexpectedly rotate identity keys, though changes are gated behind a new explicit flag and covered by tests.
Overview
Adds
--new-public-key(andMASQ_NEW_PUBLIC_KEY/config-file support) to let operators explicitly reuse the previously stored public key (off) or force generation and persistence of a new one (on) during startup.Plumbs this flag through bootstrapping/config parsing (
BootstrapperConfig.new_public_key_opt, sharedOnOffenum, setup reporter UI defaults) and updates cryptographic key initialization to honor the choice, including hard-fail cases whenoffis requested but no prior key or--db-passwordis available.Integration tests were refreshed to use
www.testingmcafeesites.comendpoints/content and improved a bookkeeping assertion for clearer mismatch diagnostics; additionally, config init now returns structured errors on unknown CLI args, and.gitignorenow ignores JetBrains Copilot files.Written by Cursor Bugbot for commit 1bc0c90. This will update automatically on new commits. Configure here.