Skip to content

Conversation

@dnwiebe
Copy link
Collaborator

@dnwiebe dnwiebe commented Aug 3, 2025

Note

Medium Risk
Touches startup configuration and persistent key selection logic; incorrect handling could cause nodes to fail to start or unexpectedly rotate identity keys, though changes are gated behind a new explicit flag and covered by tests.

Overview
Adds --new-public-key (and MASQ_NEW_PUBLIC_KEY/config-file support) to let operators explicitly reuse the previously stored public key (off) or force generation and persistence of a new one (on) during startup.

Plumbs this flag through bootstrapping/config parsing (BootstrapperConfig.new_public_key_opt, shared OnOff enum, setup reporter UI defaults) and updates cryptographic key initialization to honor the choice, including hard-fail cases when off is requested but no prior key or --db-password is available.

Integration tests were refreshed to use www.testingmcafeesites.com endpoints/content and improved a bookkeeping assertion for clearer mismatch diagnostics; additionally, config init now returns structured errors on unknown CLI args, and .gitignore now ignores JetBrains Copilot files.

Written by Cursor Bugbot for commit 1bc0c90. This will update automatically on new commits. Configure here.

@dnwiebe dnwiebe changed the base branch from GH-622-review2 to master September 1, 2025 11:35
@kauri-hero kauri-hero linked an issue Sep 5, 2025 that may be closed by this pull request
cursor[bot]

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable Changing Public Key

3 participants