Skip to content

DOC: fix doctest in util.py for greedy_splitext on Windows#5285

Open
Kd1880 wants to merge 2 commits into
MDAnalysis:developfrom
Kd1880:fix/doctest-util
Open

DOC: fix doctest in util.py for greedy_splitext on Windows#5285
Kd1880 wants to merge 2 commits into
MDAnalysis:developfrom
Kd1880:fix/doctest-util

Conversation

@Kd1880
Copy link
Copy Markdown

@Kd1880 Kd1880 commented Mar 7, 2026

Fixes part of #3925

Changes made in this Pull Request:

  • Fix doctest in greedy_splitext() in util.py
  • Added # doctest: +SKIP for platform-dependent path example that behaves differently on Windows vs Linux

LLM / AI generated code disclosure

LLMs or other AI-powered tools (beyond simple IDE use cases) were used in this contribution: yes
(Claude by Anthropic was used to help identify and understand the fix. Actual code changes were made manually.)

PR Checklist

  • Issue raised/referenced?
  • Tests updated/added? (documentation-only change, no new tests needed)
  • Documentation updated/added?
  • package/CHANGELOG file updated?
  • Is your name in package/AUTHORS?
  • LLM/AI disclosure was updated.

Developers Certificate of Origin

I certify that I can submit this code contribution as described in the Developer Certificate of Origin, under the MDAnalysis LICENSE.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.85%. Comparing base (13e8664) to head (d6a5d0b).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5285   +/-   ##
========================================
  Coverage    93.85%   93.85%           
========================================
  Files          182      182           
  Lines        22509    22509           
  Branches      3202     3202           
========================================
  Hits         21125    21125           
  Misses         922      922           
  Partials       462      462           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You removed the AI and other declarations from the PR template. Please restore them before we review this PR.

@Kd1880 Kd1880 requested a review from IAlibay March 9, 2026 09:34
Kd1880 added a commit to Kd1880/mdanalysis that referenced this pull request Mar 10, 2026
@Kd1880 Kd1880 force-pushed the fix/doctest-util branch from c6efded to d6a5d0b Compare May 23, 2026 13:44
@Kd1880
Copy link
Copy Markdown
Author

Kd1880 commented May 23, 2026

Hi @IAlibay, I've resolved the merge conflict in package/CHANGELOG by rebasing onto upstream/develop. Ready for review whenever you get a chance. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants