Reduce unnecessary work in dependency builds#1338
Draft
sbryngelson wants to merge 4 commits intoMFlowCode:masterfrom
Draft
Reduce unnecessary work in dependency builds#1338sbryngelson wants to merge 4 commits intoMFlowCode:masterfrom
sbryngelson wants to merge 4 commits intoMFlowCode:masterfrom
Conversation
- Remove invalid -DFORTRAN_LIBRARIES=ON from HDF5 (not a real HDF5 variable); explicitly disable features MFC doesn't need: HDF5_BUILD_CPP_LIB, HDF5_BUILD_FORTRAN, HDF5_ENABLE_PARALLEL - Disable ZFP compression in Silo (MFC never uses Silo compression) - Add GIT_SHALLOW to Silo clone (was missing unlike other deps)
|
Claude Code Review Incremental review from: ea00665 New findings since last Claude review:
|
- Pin Silo to 4.12.0 release tag (instead of a post-release commit hash) so GIT_SHALLOW works, making the clone faster - Disable ZFP compression in Silo (MFC never uses Silo compression) - Remove invalid -DFORTRAN_LIBRARIES=ON from HDF5 (not a real HDF5 variable); explicitly disable unneeded features: C++ bindings, Fortran bindings, and parallel I/O
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-DFORTRAN_LIBRARIES=ON(not a real HDF5 CMake variable; was a no-op). Explicitly disable C++ bindings, Fortran bindings, and parallel I/O that MFC doesn't use — fewer source files to compile.GIT_SHALLOW ON(was missing unlike other deps) and disable ZFP compression (-DSILO_ENABLE_ZFP=OFF). MFC never uses Silo compression, so this removes ~33 ZFP source files from the build.Test plan
post_processfrom clean state, verify deps build and link correctly.silooutput and confirm files are validh5dumpstill works in test suite (HDF5 tools are still enabled)