Skip to content

Disable Turbo for administrate forms - #1519

Open
jazairi wants to merge 1 commit into
mainfrom
etd-691
Open

Disable Turbo for administrate forms#1519
jazairi wants to merge 1 commit into
mainfrom
etd-691

Conversation

@jazairi

@jazairi jazairi commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Why these changes are being introduced:

In Rails 8, Turbo is enabled by default. This
causes a big with administrate form submissions
where validations don't fire, and the POST fails
silently.

Relevant ticket(s):

How this addresses that need:

This adds the data-turbo=false attribute to the
body tag of our custom admin/application
layout, which disables Turbo in all administrate
views.

Side effects of this change:

We're not leveraging Turbo in administrate, but
I'm not sure it would add value anyway.

Developer

  • All new ENV is documented in README
  • All new ENV has been added to Heroku Pipeline, Staging and Prod
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

Requires database migrations?

NO

Includes new or updated dependencies?

NO

Why these changes are being introduced:

In Rails 8, Turbo is enabled by default. This
causes a big with administrate form submissions
where validations don't fire, and the POST fails
silently.

Relevant ticket(s):

- [ETD-691](https://mitlibraries.atlassian.net/browse/ETD-691)

How this addresses that need:

This adds the `data-turbo=false` attribute to the
`body` tag of our custom `admin/application`
layout, which disables Turbo in all administrate
views.

Side effects of this change:

We're not leveraging Turbo in administrate, but
I'm not sure it would add value anyway.
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 98.25%. remained the same — etd-691 into main

@JPrevost JPrevost left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to disable in our main template too or have we tested that enough to be confident it all works?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants