Conversation
Why these changes are being introduced: In Rails 8, Turbo is enabled by default. This causes a big with administrate form submissions where validations don't fire, and the POST fails silently. Relevant ticket(s): - [ETD-691](https://mitlibraries.atlassian.net/browse/ETD-691) How this addresses that need: This adds the `data-turbo=false` attribute to the `body` tag of our custom `admin/application` layout, which disables Turbo in all administrate views. Side effects of this change: We're not leveraging Turbo in administrate, but I'm not sure it would add value anyway.
JPrevost
approved these changes
Jul 29, 2026
JPrevost
approved these changes
Jul 29, 2026
JPrevost
left a comment
Member
There was a problem hiding this comment.
Do we want to disable in our main template too or have we tested that enough to be confident it all works?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why these changes are being introduced:
In Rails 8, Turbo is enabled by default. This
causes a big with administrate form submissions
where validations don't fire, and the POST fails
silently.
Relevant ticket(s):
How this addresses that need:
This adds the
data-turbo=falseattribute to thebodytag of our customadmin/applicationlayout, which disables Turbo in all administrate
views.
Side effects of this change:
We're not leveraging Turbo in administrate, but
I'm not sure it would add value anyway.
Developer
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Code Reviewer
(not just this pull request message)
Requires database migrations?
NO
Includes new or updated dependencies?
NO