Skip to content

[PWGLF] Please consider the following formatting changes to #16933 #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Marcellocosti merged 1 commit into from
Jul 6, 2026
Merged

[PWGLF] Please consider the following formatting changes to #16933 #79

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 21 additions & 21 deletions PWGLF/Tasks/Resonances/lambda1405analysis.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2019-2020 CERN and copyright holders of ALICE O2.

Check failure on line 1 in PWGLF/Tasks/Resonances/lambda1405analysis.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/workflow-file] 

Name of a workflow file must match the name of the main struct in it (without the PWG prefix). (Class implementation files should be in "Core" directories.)
// See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
// All rights not expressly granted are reserved.
//
Expand All @@ -17,13 +17,13 @@
#include "PWGLF/DataModel/LFLambda1405Table.h"

#include "Common/Core/RecoDecay.h"
#include "Common/Core/trackUtilities.h"
#include "Common/DataModel/Centrality.h"
#include "Common/DataModel/EventSelection.h"
#include "Common/DataModel/Multiplicity.h"
#include "Common/DataModel/PIDResponseTOF.h"
#include "Common/DataModel/PIDResponseTPC.h"
#include "Common/DataModel/Qvectors.h"
#include "Common/Core/trackUtilities.h"

#include <CCDB/BasicCCDBManager.h>
#include <CommonConstants/MathConstants.h>
Expand Down Expand Up @@ -103,15 +103,15 @@
int sigmaId = 0; // Id of the Sigma candidate in MC
int bachPiId = 0; // Id of the pion candidate in MC

float centMult = -1; // Centrality of the collision
float pvContrib = -1; // Number of contributors to the primary vertex
float occ = -1; // Occupancy of the collision
float centMult = -1; // Centrality of the collision
float pvContrib = -1; // Number of contributors to the primary vertex
float occ = -1; // Occupancy of the collision

float scalarProd = -1; // Scalar product for flow analysis
};

struct lambda1405analysis {
int lambda1405PdgCode = 102132; // PDG code for Lambda(1405)

Check failure on line 114 in PWGLF/Tasks/Resonances/lambda1405analysis.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/explicit-code] 

Avoid hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
Produces<aod::Lambda1405Cands> outputDataTable; // Output table for Lambda(1405) candidates
Produces<aod::Lambda1405Flow> outputDataFlowTable; // Output table for Lambda(1405) flow analysis
Produces<aod::Lambda1405CandsMC> outputDataTableMC; // Output table for Lambda(1405) candidates in MC
Expand Down Expand Up @@ -512,7 +512,7 @@
double massSigma = isSigmaMinus ? o2::constants::physics::MassSigmaMinus : o2::constants::physics::MassSigmaPlus;

double pMother = std::sqrt(sigmaPx * sigmaPx + sigmaPy * sigmaPy + sigmaPz * sigmaPz);
if (pMother < 1e-12f) {

Check failure on line 515 in PWGLF/Tasks/Resonances/lambda1405analysis.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
LOG(info) << "Recalculation of Sigma momentum failed: mother momentum is zero " << sigmaPx << ", " << sigmaPy << ", " << sigmaPz;
return -999.f;
}
Expand All @@ -532,7 +532,7 @@
double B = -4.0 * a * K;
double C = 4.0 * eChDau * eChDau * massSigma * massSigma - K * K;

if (std::abs(A) < 1e-6f) {

Check failure on line 535 in PWGLF/Tasks/Resonances/lambda1405analysis.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
LOG(info) << "Recalculation of Sigma momentum failed: A is zero " << sigmaPx << ", " << sigmaPy << ", " << sigmaPz << ", A = " << A << ", B = " << B << ", C = " << C;
return -999.f;
}
Expand Down Expand Up @@ -862,8 +862,8 @@
return;
}
if (success) {
float sigmaPOriginal = std::sqrt(sigmaCand.pxMoth() * sigmaCand.pxMoth() +
sigmaCand.pyMoth() * sigmaCand.pyMoth() +
float sigmaPOriginal = std::sqrt(sigmaCand.pxMoth() * sigmaCand.pxMoth() +
sigmaCand.pyMoth() * sigmaCand.pyMoth() +
sigmaCand.pzMoth() * sigmaCand.pzMoth());
if (sigmaPRecalc > 0.f && sigmaPOriginal > 0.f) {
float scale = sigmaPRecalc / sigmaPOriginal;
Expand Down Expand Up @@ -980,8 +980,8 @@

// Collision properties
lambda1405Cand.pvContrib = collision.numContrib();
lambda1405Cand.centMult = getCentMult(collision);
lambda1405Cand.occ = collision.ft0cOccupancyInTimeRange();
lambda1405Cand.centMult = getCentMult(collision);
lambda1405Cand.occ = collision.ft0cOccupancyInTimeRange();

fillHistosSigma(lambda1405Cand, sigmaCand, kinkDauTrack);

Expand Down Expand Up @@ -1118,7 +1118,7 @@
for (const auto& sigmaCand : sigmaCands) {
std::vector<lambda1405candidate> selectedCandidates;
constructCollCandidates(collision, sigmaCand, tracks, selectedCandidates);
for (auto& lambda1405Cand : selectedCandidates) {

Check failure on line 1121 in PWGLF/Tasks/Resonances/lambda1405analysis.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
if (lambda1405Cand.isSigmaMinus) {
rLambda1405.fill(HIST("h2SigmaMinusMassVsLambdaMass"), lambda1405Cand.massL1405, lambda1405Cand.sigmaMinusMass);
} else {
Expand All @@ -1133,15 +1133,15 @@
}
}
if (fillOutputTree) {
outputDataTable(lambda1405Cand.px, lambda1405Cand.py, lambda1405Cand.pz,
lambda1405Cand.massL1405, lambda1405Cand.massXi1530,
lambda1405Cand.sigmaMinusMass, lambda1405Cand.sigmaPlusMass, lambda1405Cand.xiMinusMass,
lambda1405Cand.sigmaPt, lambda1405Cand.sigmaAlphaAP, lambda1405Cand.sigmaQtAP, lambda1405Cand.sigmaRadius,
lambda1405Cand.kinkPt,
lambda1405Cand.kinkPiNSigTpc, lambda1405Cand.kinkPiNSigTof,
lambda1405Cand.kinkPrNSigTpc, lambda1405Cand.kinkPrNSigTof,
lambda1405Cand.kinkDcaDauToPv,
lambda1405Cand.bachPiNSigTpc, lambda1405Cand.bachPiNSigTof);
outputDataTable(lambda1405Cand.px, lambda1405Cand.py, lambda1405Cand.pz,
lambda1405Cand.massL1405, lambda1405Cand.massXi1530,
lambda1405Cand.sigmaMinusMass, lambda1405Cand.sigmaPlusMass, lambda1405Cand.xiMinusMass,
lambda1405Cand.sigmaPt, lambda1405Cand.sigmaAlphaAP, lambda1405Cand.sigmaQtAP, lambda1405Cand.sigmaRadius,
lambda1405Cand.kinkPt,
lambda1405Cand.kinkPiNSigTpc, lambda1405Cand.kinkPiNSigTof,
lambda1405Cand.kinkPrNSigTpc, lambda1405Cand.kinkPrNSigTof,
lambda1405Cand.kinkDcaDauToPv,
lambda1405Cand.bachPiNSigTpc, lambda1405Cand.bachPiNSigTof);
} else {
outputDataFlowTable(ptCand, lambda1405Cand.massL1405,
lambda1405Cand.sigmaPt,
Expand Down Expand Up @@ -1311,9 +1311,9 @@
auto genSigma = labelSigma.template mcParticle_as<aod::McParticles>();
auto genKinkDaug = labelKinkDaug.template mcParticle_as<aod::McParticles>();

bool isSigmaMinusKink = checkSigmaKinkMC(genSigma, genKinkDaug, PDG_t::kSigmaMinus, PDG_t::kPiPlus, particlesMC);
bool isSigmaPlusToPiKink = checkSigmaKinkMC(genSigma, genKinkDaug, PDG_t::kSigmaPlus, PDG_t::kPiPlus, particlesMC);
bool isSigmaPlusToPrKink = checkSigmaKinkMC(genSigma, genKinkDaug, PDG_t::kSigmaPlus, PDG_t::kProton, particlesMC);
bool isSigmaMinusKink = checkSigmaKinkMC(genSigma, genKinkDaug, PDG_t::kSigmaMinus, PDG_t::kPiPlus, particlesMC);
bool isSigmaPlusToPiKink = checkSigmaKinkMC(genSigma, genKinkDaug, PDG_t::kSigmaPlus, PDG_t::kPiPlus, particlesMC);
bool isSigmaPlusToPrKink = checkSigmaKinkMC(genSigma, genKinkDaug, PDG_t::kSigmaPlus, PDG_t::kProton, particlesMC);

if (!isSigmaMinusKink && !isSigmaPlusToPiKink && !isSigmaPlusToPrKink) {
LOG(info) << "Candidate is not a valid Sigma kink decay, skipping ...";
Expand All @@ -1327,11 +1327,11 @@
LOG(info) << "Filling h2DeltaGenRecoPtSigmaPlus with: " << sigmaCand.ptMoth() - genSigma.pt() << ", " << sigmaCand.ptMoth();
rSigmaPlus.fill(HIST("h2DeltaGenRecoPtSigmaPlus"), sigmaCand.ptMoth() - genSigma.pt(), sigmaCand.ptMoth());
}

std::vector<lambda1405candidate> selectedCandidates;
LOG(info) << "Constructing Lambda(1405) candidates from Sigma candidate with global index: " << sigmaCand.globalIndex();
constructCollCandidates(collision, sigmaCand, tracksPerCol, selectedCandidates);
for (auto& lambda1405Cand : selectedCandidates) {

Check failure on line 1334 in PWGLF/Tasks/Resonances/lambda1405analysis.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
rLambda1405.fill(HIST("hRecoL1405"), 0., lambda1405Cand.pt()); // All reconstructed

// Do MC association
Expand Down
Loading