Skip to content

Summary panel refactor#8019

Open
danielrafailov1 wants to merge 5 commits into
MarkUsProject:masterfrom
danielrafailov1:summary-panel-refactor
Open

Summary panel refactor#8019
danielrafailov1 wants to merge 5 commits into
MarkUsProject:masterfrom
danielrafailov1:summary-panel-refactor

Conversation

@danielrafailov1

@danielrafailov1 danielrafailov1 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Proposed Changes

(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)

Refactored SummaryPanel component from react-table v6 to v8

  • Changed ReactTable components to Table components
  • Added new imports and removed old one
  • Changed criterionColumns function to use createColumnHelper
  • Changed extraMarksColumns function to use createColumnHelper

Added tests

  • to check that the Old Mark column doesn't show in the SummaryPanel when remark_submitted is false
  • to check that the Old Mark column does show in the SummaryPanel when remark_submitted is true
  • to check that the mark assigned to the user shows up in the Mark column of the SummaryPanel table
  • to check that if no mark was assigned to the user then we see a dash in the place of where the mark would be
  • to check that the old mark is shown when remark_submitted is true
Screenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality) X
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@coveralls

coveralls commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 27966245872

Coverage increased (+0.006%) to 90.273%

Details

  • Coverage increased (+0.006%) from the base build.
  • Patch coverage: 17 uncovered changes across 1 file (15 of 32 lines covered, 46.88%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
app/javascript/Components/Result/summary_panel.jsx 32 15 46.88%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 50447
Covered Lines: 46526
Line Coverage: 92.23%
Relevant Branches: 2313
Covered Branches: 1102
Branch Coverage: 47.64%
Branches in Coverage %: Yes
Coverage Strength: 127.16 hits per line

💛 - Coveralls

@david-yz-liu david-yz-liu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielrafailov1 nice work, I just left a few minor comments

if (remark_submitted) {
columns.push(
this.columnHelper.accessor("old_mark.mark", {
header: "Old Mark",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was like this in the original version as well, but please internationalize this string ("Old Mark").

meta: {
className: "number",
},
cell: info => {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the parameter name props instead of info (this is more common throughout our codebase)

this.columnHelper.accessor("description", {
header: I18n.t("activerecord.attributes.extra_mark.description"),
minSize: 150,
cell: info => {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment here (and the other cell definitions below)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants