Skip to content

parallel-workload: Fix naughty identifiers #34475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
def- merged 1 commit into from
Dec 15, 2025
Merged

parallel-workload: Fix naughty identifiers #34475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions misc/python/materialize/parallel_workload/action.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
from psycopg import Connection
from psycopg.errors import OperationalError

import materialize.parallel_workload.database
import materialize.parallel_workload.column
from materialize.data_ingest.data_type import (
NUMBER_TYPES,
Boolean,
Expand Down Expand Up @@ -221,7 +221,7 @@ def errors_to_ignore(self, exe: Executor) -> list[str]:
)
if exe.db.scenario == Scenario.Rename:
result.extend(["unknown schema", "ambiguous reference to schema name"])
if materialize.parallel_workload.database.NAUGHTY_IDENTIFIERS:
if materialize.parallel_workload.column.NAUGHTY_IDENTIFIERS:
result.extend(["identifier length exceeds 255 bytes"])
return result

Expand Down
5 changes: 5 additions & 0 deletions misc/python/materialize/parallel_workload/column.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@
NAUGHTY_IDENTIFIERS = False


def set_naughty_identifiers(value: bool) -> None:
global NAUGHTY_IDENTIFIERS
NAUGHTY_IDENTIFIERS = value


def naughtify(name: str) -> str:
"""Makes a string into a naughty identifier, always returns the same
identifier when called with the same input."""
Expand Down
4 changes: 2 additions & 2 deletions misc/python/materialize/parallel_workload/database.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
SqlServerColumn,
WebhookColumn,
naughtify,
set_naughty_identifiers,
)
from materialize.parallel_workload.executor import Executor
from materialize.parallel_workload.expression import ExprKind, expression
Expand Down Expand Up @@ -872,13 +873,12 @@ def __init__(
scenario: Scenario,
naughty_identifiers: bool,
):
global NAUGHTY_IDENTIFIERS
self.host = host
self.ports = ports
self.complexity = complexity
self.scenario = scenario
self.seed = seed
NAUGHTY_IDENTIFIERS = naughty_identifiers
set_naughty_identifiers(naughty_identifiers)

self.s3_path = 0
self.dbs = [DB(seed, i) for i in range(rng.randint(1, MAX_INITIAL_DBS))]
Expand Down