Skip to content

Refactor empty drawer value relation#4512

Open
gabriel-bolbotina wants to merge 2 commits into
masterfrom
refactor-empty-drawer-value-relation
Open

Refactor empty drawer value relation#4512
gabriel-bolbotina wants to merge 2 commits into
masterfrom
refactor-empty-drawer-value-relation

Conversation

@gabriel-bolbotina
Copy link
Copy Markdown
Contributor

Added a guard to check if there are any results fetches from the value relation model.
Modified condition for value relation editor to use full screen only if there are more than 5 elements

Modified UI:

Enregistrement.de.l.ecran.2026-05-22.a.14.25.25.mov
Enregistrement.de.l.ecran.2026-05-22.a.14.26.14.mov

@gabriel-bolbotina gabriel-bolbotina force-pushed the refactor-empty-drawer-value-relation branch from a174594 to f7a8fb3 Compare June 2, 2026 13:29
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 68811 dmg Expires: 31/08/2026 #6881
linux Build Build failed or not found. #6907
win64 Build 📬 Mergin Maps 60751 win64 Expires: 31/08/2026 #6075
Android Build 📬 Mergin Maps 819111 APK [armeabi-v7a] Expires: 31/08/2026 #8191
📬 Mergin Maps 819111 APK [armeabi-v7a] Google Play Store #8191
Android Build 📬 Mergin Maps 819151 APK [arm64-v8a] Expires: 31/08/2026 #8191
📬 Mergin Maps 819151 APK [arm64-v8a] Google Play Store #8191
iOS Build 📬 Build number: 26.06.913311 #9133

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

Coverage Report for CI Build 26822967227

Warning

No base build found for commit 93fb13e on master.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 57.934%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 15231
Covered Lines: 8824
Line Coverage: 57.93%
Coverage Strength: 99.7 hits per line

💛 - Coveralls

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 68811 dmg Expires: 31/08/2026 #6881
linux Build 📬 Mergin Maps 69072 x86_64 Expires: 01/09/2026 #6907
win64 Build 📬 Mergin Maps 60751 win64 Expires: 31/08/2026 #6075
Android Build 📬 Mergin Maps 819111 APK [armeabi-v7a] Expires: 31/08/2026 #8191
📬 Mergin Maps 819111 APK [armeabi-v7a] Google Play Store #8191
Android Build 📬 Mergin Maps 819151 APK [arm64-v8a] Expires: 31/08/2026 #8191
📬 Mergin Maps 819151 APK [arm64-v8a] Google Play Store #8191
iOS Build 📬 Build number: 26.06.913311 #9133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant