Skip to content

Change priority of error handling in synchronization error parsing #4706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomasMizera merged 1 commit into from
Sep 19, 2026
Merged

Change priority of error handling in synchronization error parsing #4706

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 18 additions & 20 deletions core/synchronizationerror.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,24 @@ SynchronizationError::SynchronizationError() = default;

SynchronizationError::ErrorType SynchronizationError::errorType( const int httpErrorCode, const QString &errorMessage, const QString &serverErrorCode )
{
//prioritise serverErrorCode parsing before httpErrorCode deduction
if ( serverErrorCode == QStringLiteral( "ProjectsLimitHit" ) )
{
return ErrorType::ProjectLimitHit;
}
if ( serverErrorCode == QStringLiteral( "StorageLimitHit" ) )
{
return ErrorType::StorageLimitHit;
}
if ( serverErrorCode == QStringLiteral( "ProjectVersionExists" ) )
{
return ErrorType::VersionMismatch;
}
if ( serverErrorCode == QStringLiteral( "AnotherUploadRunning" ) )
{
return ErrorType::AnotherProcessIsRunning;
}

if ( httpErrorCode == 400 )
{
// 'Another process is running. Please try later.'
Expand All @@ -37,26 +55,6 @@ SynchronizationError::ErrorType SynchronizationError::errorType( const int httpE
// Project no longer exists / is on different server
return ErrorType::ProjectNotFound;
}
else if ( httpErrorCode == 409 )
{
//choose depending on serverErrorCode
if ( serverErrorCode == QStringLiteral( "ProjectsLimitHit" ) )
{
return ErrorType::ProjectLimitHit;
}
if ( serverErrorCode == QStringLiteral( "StorageLimitHit" ) )
{
return ErrorType::StorageLimitHit;
}
if ( serverErrorCode == QStringLiteral( "ProjectVersionExists" ) )
{
return ErrorType::VersionMismatch;
}
if ( serverErrorCode == QStringLiteral( "AnotherUploadRunning" ) )
{
return ErrorType::AnotherProcessIsRunning;
}
}
else if ( httpErrorCode == 429 || httpErrorCode >= 500 )
{
// Exceptions in server code or maintenance mode
Expand Down
Loading