Skip to content

feat: add NOYA token metadata#1753

Open
HasanHajHasan wants to merge 2 commits intoMetaMask:masterfrom
HasanHajHasan:noya-token-metadata
Open

feat: add NOYA token metadata#1753
HasanHajHasan wants to merge 2 commits intoMetaMask:masterfrom
HasanHajHasan:noya-token-metadata

Conversation

@HasanHajHasan
Copy link

@HasanHajHasan HasanHajHasan commented Mar 12, 2026

Note

Low Risk
Adds a new ERC-20 metadata entry and logo asset only; no code paths or runtime logic change.

Overview
Adds token metadata for Noya Network (NOYA) on Base (eip155:8453), including name/symbol/decimals and a logo reference.

Introduces the corresponding SVG logo asset under icons/eip155:8453/erc20:0x0ae2ac003569b6B1e4DdB40dB098F204Fe054014.svg.

Written by Cursor Bugbot for commit 46c02af. This will update automatically on new commits. Configure here.

@HasanHajHasan HasanHajHasan requested review from a team and MRabenda as code owners March 12, 2026 22:11
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

.cls-14 {
fill: #282828;
}
</style>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SVG uses forbidden embedded CSS style block

Low Severity

The SVG contains a <style> block with embedded CSS selectors (.cls-1 through .cls-14), which the project's STYLEGUIDE.md explicitly discourages: "❌ Avoid: <style> blocks in SVG" and "Embedded CSS selectors (.cls-1 { fill: red; })." Generic class names like .cls-1 risk conflicts when multiple SVGs are rendered on the same page.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant