Skip to content

Conversation

@Qkin-Keystone
Copy link

@Qkin-Keystone Qkin-Keystone commented Dec 11, 2025

Explanation

Adds Keystone hardware keyring type and integrates display names across account tree and accounts controllers. This new keyring will be able to handle USB as a transport layer for the keystone hardware wallet.

References

MetaMask/metamask-extension#33980

Changelog

Add keystone usb keyring

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Adds Keystone hardware keyring support and wires up naming across packages.

  • Introduces KeyringTypes.keystone in KeyringController
  • Adds display names for Keystone wallet and Keystone Account in account tree rules/keyring.ts
  • Updates accounts-controller keyringTypeToName to return Keystone
  • Updates account-tree-controller CHANGELOG.md to note Keystone USB Keyring support

Written by Cursor Bugbot for commit d019c4b. This will update automatically on new commits. Configure here.

@Qkin-Keystone Qkin-Keystone requested review from a team as code owners December 11, 2025 02:08

### Added

- Add support for Keystone USB Keyring([#7440](https://github.com/MetaMask/core/pull/7440))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
- Add support for Keystone USB Keyring([#7440](https://github.com/MetaMask/core/pull/7440))
- Add support for Keystone USB Keyring ([#7440](https://github.com/MetaMask/core/pull/7440))

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks for the nit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants