fix(stellar-wallet-snap): Fill crosschain swap receive side transaction history info instead of using contract interaction by stanleyyconsensys · Pull Request #255 · MetaMask/internal-snaps

stanleyyconsensys · 2026-09-02T08:55:47Z

Explanation

This PR improves @metamask/stellar-wallet-snap transaction history mapping for Soroban invoke-host-function transactions by detecting wallet-credited SAC transfer contract events in result_meta_xdr, allowing these credits (native and classic CODE:ISSUER) to be surfaced as Receive transactions rather than Unknown.

Changes:

Add generic parsing utilities to walk contract events from Horizon result_meta_xdr and safely parse SAC transfer events credited to a given account.
Extend TransactionMapper to map eligible invoke-host-function transactions as receives based on parsed contract events (native + classic assets).

Video reference:
https://www.loom.com/share/967c2716a3d14cf085c140fdea5376eb

References

Checklist

I've updated the test suite for new or updated code as appropriate
I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
I've communicated my changes to consumers by updating changelogs for packages I've changed
I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Copilot

🟡 Changes recommended

parseContractEventsFromResultMeta contains a confirmed switch fallthrough bug that breaks V3 meta parsing and can cause valid contract events to be dropped.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR improves @metamask/stellar-wallet-snap transaction history mapping for Soroban invoke-host-function transactions by detecting wallet-credited SAC transfer contract events in result_meta_xdr, allowing these credits (native and classic CODE:ISSUER) to be surfaced as Receive transactions rather than Unknown.

Changes:

Add generic parsing utilities to walk contract events from Horizon result_meta_xdr and safely parse SAC transfer events credited to a given account.
Extend TransactionMapper to map eligible invoke-host-function transactions as receives based on parsed contract events (native + classic assets).
Add fixtures and unit tests covering receive mapping for contract swap credits; update the package changelog.

File summaries

File	Description
packages/stellar-wallet-snap/src/services/transaction/xdrParser.ts	Adds contract-event extraction from `result_meta_xdr` and a safe SAC `transfer` parser for receive detection.
packages/stellar-wallet-snap/src/services/transaction/xdrParser.test.ts	Adds unit tests for parsing credited SAC transfers from transaction meta.
packages/stellar-wallet-snap/src/services/transaction/TransactionMapper.ts	Adds invoke-host-function receive fallback mapping driven by meta contract events.
packages/stellar-wallet-snap/src/services/transaction/TransactionMapper.test.ts	Adds mapping coverage for native + USDC contract-swap receive scenarios.
packages/stellar-wallet-snap/src/services/transaction/mocks/horizon-transaction-responses.fixtures.ts	Introduces Horizon fixtures containing `result_meta_xdr` with SAC transfer events.
packages/stellar-wallet-snap/CHANGELOG.md	Adds an Unreleased “Fixed” entry describing the improved receive mapping.

Review details

Files reviewed: 6/6 changed files
Comments generated: 2
Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

stanleyyconsensys · 2026-09-02T09:16:22Z

+  describe('parseContractEventsFromResultMeta', () => {
+    it('accumulates native SAC transfers credited to the wallet', () => {
+      const results = parseContractEventsFromResultMeta({


we cover it via fixture already

Copilot

🟡 Changes recommended

The new XDR parsing introduces multiple unexplained magic-number union discriminants that should be replaced with named switch values/SDK enums to reduce brittleness and improve maintainability.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Suppressed comments (2)

packages/stellar-wallet-snap/src/services/transaction/xdrParser.ts:597

This V4 branch also relies on a numeric meta version (case 4). For readability/consistency with the rest of xdrParser.ts (which uses .switch().name checks), consider using the named discriminant or an SDK enum constant here as well to avoid unexplained magic numbers.

      case 4: {
        events = meta
          .v4()
          .operations()
          .flatMap((op) => [...op.events()]);
        break;

packages/stellar-wallet-snap/src/services/transaction/xdrParser.ts:637

parseTransferContractEventSafe checks body.switch() !== 0, which is an unexplained magic number. For consistency with the rest of this file (which typically uses switch().name), consider comparing against the named contract event body type or the SDK enum constant instead of 0 so it’s obvious which event-body variant is being parsed.

    const body = event.body();
    if (body.switch() !== 0) {
      return null;
    }

Files reviewed: 6/6 changed files
Comments generated: 1
Review effort level: Lite

stanleyyconsensys · 2026-09-03T14:23:18Z

+      typeof toAddress !== 'string' ||
+      typeof token !== 'string' ||
+      toAddress !== accountAddress
+    ) {


@Julink-eth we can just add
toAddress !== fromAddress as safe guard to ensure the txn is a receive txn

Yes I think we should add it after our discussion.

Julink-eth · 2026-09-03T15:08:20Z

@metamaskbot publish-preview

github-actions · 2026-09-03T15:11:48Z

Preview builds have been published. Learn how to use preview builds in other projects.

Expand for full list of packages and versions.

@metamask-previews/bitcoin-wallet-snap@2.0.1-preview-a9a1b93a
@metamask-previews/snap-networks-utils@1.0.0-preview-a9a1b93a
@metamask-previews/solana-wallet-snap@6.0.0-preview-a9a1b93a
@metamask-previews/stellar-wallet-snap@0.1.0-preview-a9a1b93a
@metamask-previews/tron-wallet-snap@3.2.0-preview-a9a1b93a

fix: txn history with empty account

4f2380f

stanleyyconsensys requested a review from a team as a code owner September 2, 2026 08:55

stanleyyconsensys deployed to default-branch September 2, 2026 08:55 — with GitHub Actions Active

stanleyyconsensys changed the title ~~fix: txn history with empty account~~ fix(stellar-wallet-snap): txn history with empty account Sep 2, 2026

Update CHANGELOG.md

5c334af

stanleyyconsensys requested a lite review from Copilot September 2, 2026 09:00

Copilot started reviewing on behalf of stanleyyconsensys September 2, 2026 09:00 View session

Copilot AI reviewed Sep 2, 2026

View reviewed changes

stanleyyconsensys added 3 commits September 2, 2026 17:18

fix: comment

bc3fed7

Update xdrParser.ts

63301c9

Merge branch 'main' into fix/contract-txn-receive

f9737a9

stanleyyconsensys changed the title ~~fix(stellar-wallet-snap): txn history with empty account~~ fix(stellar-wallet-snap): Fill transaction history info instead of contract interaction if it is a cross chain swap receive side transaction Sep 3, 2026

stanleyyconsensys changed the title ~~fix(stellar-wallet-snap): Fill chain swap receive side transaction history info instead of using contract interaction~~ fix(stellar-wallet-snap): Fill crooschain swap receive side transaction history info instead of using contract interaction Sep 3, 2026

stanleyyconsensys changed the title ~~fix(stellar-wallet-snap): Fill crooschain swap receive side transaction history info instead of using contract interaction~~ fix(stellar-wallet-snap): Fill crosschain swap receive side transaction history info instead of using contract interaction Sep 3, 2026

Update CHANGELOG.md

76c30fa

stanleyyconsensys requested a lite review from Copilot September 3, 2026 02:03

Copilot started reviewing on behalf of stanleyyconsensys September 3, 2026 02:03 View session

Copilot AI reviewed Sep 3, 2026

View reviewed changes

Comment thread packages/stellar-wallet-snap/src/services/transaction/xdrParser.ts

stanleyyconsensys added 3 commits September 3, 2026 10:30

chore: simplify menthod

ef789d9

Update xdrParser.test.ts

0571493

fix: lint

1d92358

stanleyyconsensys enabled auto-merge September 3, 2026 03:35

stanleyyconsensys commented Sep 3, 2026

View reviewed changes

Update TransactionMapper.ts

a9a1b93

Navigation Menu

Uh oh!

fix(stellar-wallet-snap): Fill crosschain swap receive side transaction history info instead of using contract interaction - #255

fix(stellar-wallet-snap): Fill crosschain swap receive side transaction history info instead of using contract interaction#255
stanleyyconsensys wants to merge 10 commits into
mainfrom
fix/contract-txn-receive

stanleyyconsensys commented Sep 2, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

stanleyyconsensys Sep 2, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

stanleyyconsensys Sep 3, 2026 •

edited

Loading

Uh oh!

Julink-eth Sep 3, 2026

Uh oh!

Julink-eth commented Sep 3, 2026

Uh oh!

github-actions Bot commented Sep 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

stanleyyconsensys commented Sep 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation

Changes:

References

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

stanleyyconsensys Sep 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Suppressed comments (2)

Uh oh!

Uh oh!

stanleyyconsensys Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Julink-eth Sep 3, 2026

Choose a reason for hiding this comment

Uh oh!

Julink-eth commented Sep 3, 2026

Uh oh!

github-actions Bot commented Sep 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

stanleyyconsensys commented Sep 2, 2026 •

edited

Loading

stanleyyconsensys Sep 3, 2026 •

edited

Loading