Skip to content

feat(solana-wallet-snap): add batch proof-of-ownership signing - #256

Open
hmalik88 wants to merge 4 commits into
mainfrom
hm/mul-2183
Open

feat(solana-wallet-snap): add batch proof-of-ownership signing#256
hmalik88 wants to merge 4 commits into
mainfrom
hm/mul-2183

Conversation

@hmalik88

@hmalik88 hmalik88 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Explanation

Adds signProofOfOwnershipBatch to the Solana snap so MetaMask can request proof-of-ownership signatures for multiple accounts in one snap call.
The batch path:

  • resolves requested accounts with one account lookup instead of one lookup per item
  • validates proof messages per item
  • returns per-item success/error results so one bad account or message does not fail the whole batch
  • groups signing by entropySource
  • fetches the Solana coin-type node (m/44'/501') once per entropy source
  • derives account keys locally from the coin-type node before signing

References

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

@hmalik88
hmalik88 marked this pull request as ready for review September 3, 2026 13:41
@hmalik88
hmalik88 requested a review from a team as a code owner September 3, 2026 13:41
@hmalik88
hmalik88 deployed to default-branch September 3, 2026 13:41 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant