feat(bitcoin-wallet-snap)!: remove assets handlers

packages/bitcoin-wallet-snap/CHANGELOG.md

@@ -19,6 +19,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Process the entire requested account range as a single batch instead of chunks of 100, so the existing-accounts lookup and state I/O happen once per request ([#221](https://github.com/MetaMask/internal-snaps/pull/221))
 - Split the chain `stopGap` configuration into `{ discovery: 5, scan: 20 }` so account discovery keeps the cheap probe while full account scans use the BIP44 gap limit ([#224](https://github.com/MetaMask/internal-snaps/pull/224))
 
+### Removed
+
+- **BREAKING** Remove the `onAssetsLookup`, `onAssetsConversion`, `onAssetHistoricalPrice`, and `onAssetsMarketData` asset handler entry points, along with the now-unused `AssetsHandler`, `AssetsUseCases`, `InMemoryCache`, `ICache`, and the `endowment:assets` permission ([#260](https://github.com/MetaMask/internal-snaps/pull/260))
+
 ### Fixed
 
 - Coalesce concurrent account synchronization runs so stacked triggers (the 30s cronjob, `onActive`, and background events scheduled by `setSelectedAccounts`) share one run instead of duplicating network fetches, state writes, and keyring events ([#221](https://github.com/MetaMask/internal-snaps/pull/221))

packages/bitcoin-wallet-snap/jest.config.mjs

@@ -24,10 +24,10 @@ const config = {
   // An object that configures minimum threshold enforcement for coverage results
   coverageThreshold: {
     global: {
-      branches: 65.5,
-      functions: 61.63,
-      lines: 75.29,
-      statements: 74.57,
+      branches: 72.43,
+      functions: 57.43,
+      lines: 81.02,
+      statements: 80.75,
     },
   },
 

packages/bitcoin-wallet-snap/snap.manifest.json

@@ -7,7 +7,7 @@
     "url": "https://github.com/MetaMask/internal-snaps.git"
   },
   "source": {
-    "shasum": "OTDuRBGySZDr4ORVHDw93PFlyEWUOUA9wtUXm4HgHiY=",
+    "shasum": "aFQ3IzhV1Uq960fx3NsYY0RhOmZiB+KVOvkvBFvcMPQ=",
     "location": {
       "npm": {
         "filePath": "dist/bundle.js",
@@ -87,15 +87,6 @@
           }
         }
       ]
-    },
-    "endowment:assets": {
-      "scopes": [
-        "bip122:000000000019d6689c085ae165831e93",
-        "bip122:000000000933ea01ad0ee984209779ba",
-        "bip122:00000000da84f2bafbbc53dee25a72ae",
-        "bip122:00000008819873e925422c1ff0f99f7c",
-        "bip122:regtest"
-      ]
     }
   },
   "platformVersion": "12.0.1",

packages/bitcoin-wallet-snap/src/config.ts

@@ -60,6 +60,5 @@ export const Config: SnapConfig = {
   priceApi: {
     url: fromEnv('PRICE_API_URL', 'https://price.api.cx.metamask.io'),
   },
-  conversionsExpirationInterval: 60,
   defaultAddressType: fromEnv('DEFAULT_ADDRESS_TYPE', 'p2wpkh') as AddressType,
 };

packages/bitcoin-wallet-snap/src/entities/account.ts

@@ -385,14 +385,6 @@ export const addressTypeToPurpose: Record<AddressType, Purpose> = {
   p2tr: Purpose.Taproot,
 };
 
-export const purposeToAddressType: Record<Purpose, AddressType> = {
-  [Purpose.Legacy]: 'p2pkh',
-  [Purpose.Segwit]: 'p2sh',
-  [Purpose.Multisig]: 'p2wsh',
-  [Purpose.NativeSegwit]: 'p2wpkh',
-  [Purpose.Taproot]: 'p2tr',
-};
-
 export const networkToCoinType: Record<Network, Slip44> = {
   bitcoin: Slip44.Bitcoin,
   testnet: Slip44.Testnet,

packages/bitcoin-wallet-snap/src/entities/config.ts

@@ -9,7 +9,6 @@ export type SnapConfig = {
   fallbackFeeRate: number;
   ratesRefreshInterval: string;
   priceApi: PriceApiConfig;
-  conversionsExpirationInterval: number;
   defaultAddressType: AddressType;
 };
 

packages/bitcoin-wallet-snap/src/entities/rates.ts

@@ -1,12 +1,4 @@
-import type {
-  HistoricalPriceValue,
-  FungibleAssetMarketData,
-} from '@metamask/snaps-sdk';
-import type { CaipAssetType } from '@metamask/utils';
-
-export type TimePeriod = 'P1D' | 'P7D' | 'P1M' | 'P3M' | 'P1Y' | 'P1000Y';
-
-export type AssetRate = [CaipAssetType, SpotPrice | null];
+import type { FungibleAssetMarketData } from '@metamask/snaps-sdk';
 
 export type SpotPrice = {
   price: number;
@@ -21,17 +13,4 @@ export type AssetRatesClient = {
    * @param baseCurrency - the currency to get prices for. Defaults to 'bitcoin'.
    */
   spotPrices(vsCurrency?: string, baseCurrency?: string): Promise<SpotPrice>;
-
-  /**
-   * Returns a list of historical prices for a token against another.
-   *
-   * @param timePeriod - the time period to fetch prices for.
-   * @param vsCurrency - the currency to convert prices to. Defaults to 'usd'.
-   * @param baseCurrency - the currency to get prices for. Defaults to 'bitcoin'.
-   */
-  historicalPrices(
-    timePeriod: TimePeriod,
-    vsCurrency?: string,
-    baseCurrency?: string,
-  ): Promise<HistoricalPriceValue[]>;
 };