feat(stellar-wallet-snap)!: remove assets handlers - #262
Open
ulissesferreira wants to merge 1 commit into
Open
Conversation
ulissesferreira
force-pushed
the
WPN-2014-remove-asset-handlers
branch
from
September 2, 2026 17:31
3ae3fd4 to
734f1ce
Compare
stanleyyconsensys
left a comment
stanleyyconsensys
left a comment
Contributor
There was a problem hiding this comment.
we can do more clean up, but it also work if we just remove the entry
| const { conversions } = params; | ||
|
|
||
| const conversionRates = | ||
| await this.#priceService.getMultipleTokenConversions(conversions); |
Contributor
There was a problem hiding this comment.
getMultipleTokenConversions
getMultipleTokensMarketData
getHistoricalPriceWithAllTimePeriods
can be remove from
- PriceService
- price.fixtures
Contributor
Author
There was a problem hiding this comment.
Should be included now ✅
ulissesferreira
force-pushed
the
WPN-2014-remove-asset-handlers
branch
from
September 3, 2026 16:39
734f1ce to
03a7326
Compare
ulissesferreira
force-pushed
the
WPN-2014-remove-asset-handlers
branch
from
September 4, 2026 08:59
03a7326 to
15459e9
Compare
Remove the onAssetsLookup, onAssetsConversion, onAssetHistoricalPrice, and onAssetsMarketData entry points, along with the now-unused AssetsHandler module and the endowment:assets permission. Closes WPN-2014
ulissesferreira
force-pushed
the
WPN-2014-remove-asset-handlers
branch
from
September 4, 2026 09:15
15459e9 to
e7a796a
Compare
|
ulissesferreira
changed the title
assets handlers
Contributor
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes WPN-2014
Summary
onAssetsLookup,onAssetsConversion,onAssetHistoricalPrice, andonAssetsMarketDataentry points fromstellar-wallet-snapAssetsHandlermodule (src/handlers/asset/)endowment:assetspermission from the manifestThe
AssetMetadataService,PriceService, andsrc/api/assetstructs are kept since they are used by client request handlers, cronjobs, and sync services.Breaking change
The asset handler entry points are no longer exported by the snap.