Update intelligent-query-processing-memory-grant-feedback.md - #10365
Conversation
|
Learn Build status updates of commit 4c04f86:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| docs/relational-databases/performance/intelligent-query-processing-memory-grant-feedback.md | Details |
docs/relational-databases/performance/intelligent-query-processing-memory-grant-feedback.md
- Line 1, Column 1: [Warning: author-missing - See documentation]
Missing required attribute: 'author'. Add the current author's GitHub ID. - Line 1, Column 1: [Warning: title-missing - See documentation]
Missing required attribute: 'title'. Add a title string to show in search engine results. - Line 1, Column 1: [Warning: ms-author-missing - See documentation]
Missing required attribute: 'ms.author'. Add the current author's Microsoft alias. - Line 1, Column 1: [Warning: ms-topic-missing - See documentation]
Missing required attribute: 'ms.topic'. - Line 11, Column 1: [Warning: yaml-header-syntax-error - See documentation]
While parsing a block mapping, did not find expected key. - Line 1, Column 1: [Suggestion: ms-date-missing - See documentation]
Missing required attribute: 'ms.date'. - Line 1, Column 1: [Suggestion: description-missing - See documentation]
Missing required attribute: 'description'. - Line 1, Column 1: [Suggestion: ms-service-suggested]
Missing required attribute: 'ms.service'. ms.service is suggested for each article that is published on Learn.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
|
Randolph West MSFT (@rwestMSFT) Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
prmerger-automator
Bot
added
the
aq-pr-triaged
There was a problem hiding this comment.
Pull request overview
This PR updates the Memory Grant Feedback documentation to reflect that persistence (and related feedback persistence) is available in Azure SQL Managed Instance, removing the prior statement that it isn’t.
Changes:
- Update the “Percentile and persistence mode memory grant feedback” section to include Azure SQL Managed Instance for persistence defaults.
- Remove the bullet stating percentile/persistence isn’t available in Azure SQL Managed Instance.
- (Unintended) Front matter change appears to break YAML formatting for
f1_keywords.
| f1_keywords:mana | ||
| - "memory grant feedback" | ||
| helpviewer_keywords: | ||
| - "memory grant feedback" |
| - Percentile memory grant feedback is enabled by default in [!INCLUDE [ssSQL22](../../includes/sssql22-md.md)], but has no effect if Query Store isn't enabled or when Query Store isn't in a "read write" state. | ||
|
|
||
| - Persistence for memory grant, CE, and DOP feedback is on by default in [!INCLUDE [ssSQL22](../../includes/sssql22-md.md)], but has no effect when Query Store isn't enabled or when Query Store isn't in a "read write" state. | ||
| - Persistence for memory grant, CE, and DOP feedback is on by default in [!INCLUDE [ssSQL22](../../includes/sssql22-md.md)] and [!INCLUDE [ssazuremi-md](../../includes/ssazuremi-md.md)], but has no effect when Query Store isn't enabled or when Query Store isn't in a "read write" state. | ||
|
|
||
| - Percentile and persistence for memory grant feedback is available in [!INCLUDE [ssazure-sqldb](../../includes/ssazure-sqldb.md)], and enabled by default on all databases, both existing and new. |
|
Learn Build status updates of commit c990f78: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Learn Build status updates of commit 5dba5e1: ✅ Validation status: passed
For more details, please refer to the build report. |
|
sommarskog We've had some internal discussions about this PR and might modify the underlying article. I'll keep the PR open for now as a reminder to us. |
|
Yeah, I am not entirely fond of this topic, as pieces have been added as the new features have been coming in, so a fresh start would be welcome. I decided not to go there myself, but only correct the information about MI. |
|
Learn Build status updates of commit f582d30: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Learn Build status updates of commit 0a6c8cd: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue.
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
Topic said that persistence of memory-grant-feedback and percentile testing is currently not available in Azure Managed Instance. My testing indicates that it is, and I assume that the text I deleted was a leftover.
Co-authored-by: Regan Downer <v-rdowner@microsoft.com>
Apply batched suggestions from code review Co-authored-by: Derek Wilson <34077013+thesqlsith@users.noreply.github.com> Co-authored-by: Randolph West MSFT <97149825+rwestMSFT@users.noreply.github.com> Init Apply suggestion from @rwestMSFT
0a6c8cd to
db4ee69
Compare
|
Learn Build status updates of commit db4ee69: ✅ Validation status: passed
For more details, please refer to the build report. |
3777db5
into
MicrosoftDocs:live
|
PR 10365 has been merged from sommarskog:patch-31 to MicrosoftDocs:live by rwestMSFT. sommarskog, Richard West (@rwest), Randolph West MSFT (@rwestMSFT) |
Topic said that persistence of memory-grant-feedback and percentile testing is currently not available in Azure Managed Instance. My testing indicates that it is, and I assume that the text I deleted was a leftover.