feat: table、equation质检prompt#377
Merged
shijinpjlab merged 2 commits intoMigoXLab:devfrom Mar 31, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces two new LLM-based text quality assessment models: LLMTextEquation for evaluating mathematical formulas and LLMTextTable for evaluating HTML tables. The review feedback highlights that the metric_name and description metadata are currently too generic and should be specialized for each class to improve documentation. Furthermore, there are suggestions to maintain case consistency for the 'none' error type in the prompts and to correct a copy-paste error in the table quality prompt where 'equation' was incorrectly referenced instead of 'table'.
Comment on lines
+11
to
+12
| "metric_name": "LLMTextQualityV5", | ||
| "description": "Impact-driven text quality evaluation for LLM pretraining, focusing on structural completeness, readability, diversity, and safety with quantitative thresholds", |
Contributor
| Return JSON only: {"score": 0/1, "type": "", "name": "", "reason": ""} | ||
|
|
||
| score 类型必须为int; | ||
| score 为 1 表示通过,type 填 "Good",name 填 "None",reason 说明公式正常的依据; |
Contributor
Comment on lines
+11
to
+12
| "metric_name": "LLMTextQualityV5", | ||
| "description": "Impact-driven text quality evaluation for LLM pretraining, focusing on structural completeness, readability, diversity, and safety with quantitative thresholds", |
Contributor
| Return JSON only: {"score": 0/1, "type": "", "name": "", "reason": ""} | ||
|
|
||
| score 类型必须为int; | ||
| score 为 1 表示通过,type 填 "Good",name 填 "None",reason 说明公式正常的依据; |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.