Skip to content

Fix plugin calls crashing on iOS: depend on WasmKit with wasmkit_tc_start in C #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colemancda merged 2 commits into from
Nov 4, 2026
Merged

Fix plugin calls crashing on iOS: depend on WasmKit with wasmkit_tc_start in C #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bba56c
Depend on the WasmKit fork with wasmkit_tc_start defined in C, so cal…
colemancda Nov 4, 2026
f4719a1
Resolve WasmKit at 80990b7
colemancda Nov 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 12 additions & 7 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,20 @@ let package = Package(
// SwiftUI for Android. Apple platforms use the system SwiftUI instead, so this is only
// linked for .android — see the conditional target dependencies below.
.package(url: "https://github.com/PureSwift/AndroidSwiftUI.git", branch: "master"),
// Fork of WasmKit 0.3.1 with one change: upstream declares
// `.treatAllWarnings(as: .error)` for Apple platforms, which collides with the
// `-suppress-warnings` Xcode passes to package dependencies and makes the app fail to build
// in Xcode ("Conflicting options '-warnings-as-errors' and '-suppress-warnings'"). That
// setting only reaches package targets from the command line, so it cannot be overridden
// from the xcconfig or the project. Track upstream and drop the fork once it is fixed there.
// Fork of WasmKit 0.3.1 with two changes:
// - Upstream declares `.treatAllWarnings(as: .error)` for Apple platforms, which collides
// with the `-suppress-warnings` Xcode passes to package dependencies and makes the app
// fail to build in Xcode ("Conflicting options '-warnings-as-errors' and
// '-suppress-warnings'"). That setting only reaches package targets from the command
// line, so it cannot be overridden from the xcconfig or the project.
// - `wasmkit_tc_start` is defined in C rather than inline. Inlined into Swift, the call to
// the first direct-threaded handler assumed the handlers keep x22, which they do not, and
// every call into a plugin crashed in optimized builds when memory bounds are checked in
// software, as they are on iOS.
// Track upstream and drop the fork once both are fixed there.
.package(
url: "https://github.com/MillerTechnologyPeru/WasmKit.git",
revision: "ba06b7c64b5bc692c19c301ba2ef843c8d0f37c2"
revision: "80990b79f7d8aaf222cf806afa6252733acfa603"
)
],
targets: [
Expand Down
Loading