[refactor] Remove redundant code related to text vnodes#3066
Open
kfule wants to merge 3 commits intoMithrilJS:mainfrom
Open
[refactor] Remove redundant code related to text vnodes#3066kfule wants to merge 3 commits intoMithrilJS:mainfrom
kfule wants to merge 3 commits intoMithrilJS:mainfrom
Conversation
Since MithrilJS#2670, `vnode.text` and its related interfaces are no longer used internally.
… new values In text vnodes, `vnode.children` is already normalized by `String()`, so the `toString()` here is redundant.
dead-claudia
approved these changes
Jan 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the following redundant code:
vnode.text-related code, which has not been used internally since Standardise vnode text representation #2670.toString()calls used to compare old and new strings inupdateText. Both strings have already been normalized viaString().npm run testpasses as-is.Motivation and Context
This PR is expected to slightly improve bundle size and performance.
In addition, the
vnode.text-related code appears very early in the mithril.js build bundle; removing it also improves readability.How Has This Been Tested?
npm run testTypes of changes
Checklist