Skip to content

Remove the heading that repeats the title of random-variables.qmd - #298

Merged
dem-extra1 merged 2 commits into
mainfrom
claude/project-thread-ykzrw4
Nov 1, 2026
Merged

dem-extra1 merged 2 commits into
mainfrom
claude/project-thread-ykzrw4

Conversation

@dem-extra1

Copy link
Copy Markdown
Contributor

Closes #297.

The page title is the level 1 heading, so ## Random variables as the first section repeated it.
The heading is dropped and its id sec-random-variables stays on an empty anchor []{#sec-random-variables} at the top of the page, so links to it keep working.

Rendered random-variables.qmd to HTML: the title is the only level 1 heading, the first section is "Characteristics of probability distributions", and the sec-random-variables id is present.

Thread: Fix heading levels in split-out pages (project thread). Related check: Morrison-Lab/gha#1373.


Generated by Claude Code

Keep the sec-random-variables id on an empty anchor.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrDiMYAnjPMHWVTPJfZ
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

Claude finished review — View run


I fetched PR #298 live just now. It is OPEN, not a draft and not merged (mergedAt is null). Its head is add2e8c99ba30936d0ac9d55530d071a4a38d2c0, the commit I reviewed, so the verdict below still applies.

Since the previous review, the only change is the reworded HTML comment at random-variables.qmd:17. It no longer refers to the removed heading, which settles the stale-comment point from that round. The diff has no math, so the macro check does not apply.

Verdict

Ready for merge

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "add2e8c99ba30936d0ac9d55530d071a4a38d2c0",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "The new commit only rewords an HTML comment in random-variables.qmd so it no longer refers to the removed heading; rendered output is unchanged.",
  "holistic_assessment": "The PR stays narrowly scoped, keeps the sec-random-variables anchor intact for external links, and resolves the stale-comment point from the prior review."
}

Reviewed commit: add2e8c

@github-actions

Copy link
Copy Markdown
Contributor

💰 Cost: $0.1938 (review) — run

@dem-extra1

Copy link
Copy Markdown
Contributor Author

🤖 Antigravity agent report

Cross-harness review (Gemini 3.8 Flash (Medium) via Antigravity agy 1.3.5, standing in while Argon quota is exhausted, read-only plan mode) at add2e8c

I gave the model the full diff (one file: the title-repeating heading replaced by []{#sec-random-variables}, and one reworded comment) and these facts, which I checked in the file at this head: the remaining headings are ## Characteristics of probability distributions, ## Survival, hazard, and cumulative hazard functions {#sec-prob-haz} and ## References, so no level is skipped; and a code search of the organisation finds sec-random-variables only in this file, so no @sec-random-variables cross-reference elsewhere depends on the id being a heading (an empty span is not a heading, so such a reference would not resolve through it, while a link to random-variables.html#sec-random-variables still works).
The model reported that the replacement is correct, that the anchor syntax is valid, that the reworded comment ("the first slide after the title slide holds the def-random-variable div") is accurate, and that nothing depends on the removed heading; it found nothing.
The empty anchor renders as an empty paragraph at the top of the page, the same tradeoff that mds#545 states and accepts.
Nothing was rendered, so I did not see the page or the slides.

Verdict

VERDICT: CLEAN

Reviewed-Commit: add2e8c

Posted by Claude Code (AI agent) --- not written by a human.

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.

2026-11-01 08:56 UTC

@dem-extra1
dem-extra1 merged commit 5c3fed9 into main Nov 1, 2026
36 checks passed
@dem-extra1
dem-extra1 deleted the claude/project-thread-ykzrw4 branch November 1, 2026 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the heading that repeats the title of random-variables.qmd

2 participants