Conversation
…lates Semantic cleanup in diffChanges merged small inline changes into one block, hiding per-change highlights for text without word boundaries (e.g. CJK). The cleanup is now opt-out (default on), and prebuilt fast-diff templates are kept at render time when setEnableFastDiffTemplate(true) is set.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #73.
Problem
Multiple small insertions on one line (common in CJK text without word boundaries) render as a single highlight block, because
diffChangeshardcodes semantic cleanup (fastDiff(a, b, 0, true)), and because render always rebuilds the single-span template even whensetEnableFastDiffTemplate(true)is set (so that flag has no visible effect today).Changes
packages/core/src/parse/change-range.ts: newsetEnableDiffSemanticCleanup/getEnableDiffSemanticCleanup/resetEnableDiffSemanticCleanup(defaulttrue, backward compatible), following the existing config convention in the same file.packages/core/src/parse/template.ts:getPlainDiffTemplate/getSyntaxDiffTemplatekeep a prebuiltfast-difftemplate whensetEnableFastDiffTemplate(true)is set; default rendering is untouched.README.md: documented the new flag next to the FastDiff Template section.Verification
Bundled the modified sources and diffed
A、B、C→A[x]、B[y]、C[z]:[x]/[y]/[z]spans.eslintandprettier --checkpass on the changed files (repo has no test runner).