Add a module to convert straw digis to artdaq fragments#1775
Open
michaelmackenzie wants to merge 3 commits intoMu2e:mainfrom
Open
Add a module to convert straw digis to artdaq fragments#1775michaelmackenzie wants to merge 3 commits intoMu2e:mainfrom
michaelmackenzie wants to merge 3 commits intoMu2e:mainfrom
Conversation
Collaborator
|
Hi @michaelmackenzie,
which require these tests: build. @Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main. ⌛ The following tests have been triggered for 9649ba9: build (Build queue - API unavailable) |
Collaborator
|
☔ The build tests failed for 9649ba9.
N.B. These results were obtained from a build of this Pull Request at 9649ba9 after being merged into the base branch at b4e91ff. For more information, please check the job page here. |
pavel1murat
approved these changes
Mar 30, 2026
Contributor
pavel1murat
left a comment
There was a problem hiding this comment.
let it be. I approve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was mostly generated using AI. It produces artdaq fragments from straw digis/waveforms. The goal is to have fragments from Offline simulations to help characterize the Online trigger while waiting for real beam data. The actual panel mapping won't be very sensible here yet, so I had to add the option to override the panel mapping with the Offline straw ID.
I validated that on 1k events I get identical digi collections (including waveforms). I also found when using the calo version of this as well I get identical trigger results on these 1k events (after correcting a bug in calo reco that introduces digi collection order dependence, which Bertrand is aware of an investigating).
Here is an example fcl to test this:
Once this and the calo PR (#1774) are merged, I believe we'll be ready to repeat trigger timing studies, this time starting from fragments.