Add PSVR2-compatible left/right controller detection#10
Open
WolfWings wants to merge 1 commit into
Open
Conversation
Fixes MyroG#9 PSVR2 is the most (in)famous example that doesn't name it's controllers Left/Right, but shoehorns it in with (R) and (L) instead. This tiny patch adds a second set of checks for this alternative left/right naming scheme. It does not attempt to "optimize" things by caching the toLower call into a variable, as compilers for over 20 years have done common subexpression elimination so simple readable code w/ contextual comments for the new lines seemed preferable for this patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9
PSVR2 is the most (in)famous example that doesn't name it's controllers Left/Right, but shoehorns it in with (L) and (R) instead.
This tiny patch adds a second set of checks for this alternative left/right naming scheme.
It does not attempt to "optimize" things by caching the toLower call into a variable, as compilers for over 20 years have done common subexpression elimination so simple readable code w/ contextual comments for the new lines seemed preferable for this patch.