(new) Call security context validators during action-set validation#210
(new) Call security context validators during action-set validation#210mfarina1 wants to merge 12 commits into
Conversation
|
FYI if calls are not crossing component boundaries (i.e. between files in the same source directory) they do not need to use the frontend APIs. For example, your iterations can access the member fields directly to avoid excessive indirection. |
…//github.com/NASA-AMMOS/BSL into 184-call-security-context-validate-functions
BrianSipos
left a comment
BrianSipos
left a comment
There was a problem hiding this comment.
Some feedback about these edits, and about the BSL response to validation failure of individual actions.
| if (!sec_ctx->validate(lib, bundle, sec_oper)) | ||
| { | ||
| BSL_LOG_WARNING("Security context validator failed for context ID %" PRId64, sec_oper->context_id); | ||
| return BSL_ERR_SECURITY_CONTEXT_VALIDATION_FAILED; |
There was a problem hiding this comment.
Does the response to this need to be more nuanced?
If a single op of a single action fails, should only that one action be affected?
Maybe the action needs a valid/invalid marking set here that the BSL can use after all validation is finished...?
There was a problem hiding this comment.
Refactored actions/action sets. Actions now include "validated" bool flag
|
3 participants
This PR closes #184 and is very similar to the closed PR #190 ; however, this incorporates Josh's feedback on that old PR.