Fix elevation processing issues duning rendering#237
Open
EMaksymenko wants to merge 2 commits intoNASAWorldWind:developfrom
Open
Fix elevation processing issues duning rendering#237EMaksymenko wants to merge 2 commits intoNASAWorldWind:developfrom
EMaksymenko wants to merge 2 commits intoNASAWorldWind:developfrom
Conversation
Calculate correct GL near clip distance and limit Navigator to avoid terrain collisions. Fix lookAt point calculation for gesture begin - take terrain altitude in consideration. Add terrain elevation output into example application. Navigator tests were commented as it is now dependent on context.
…r before processing.
PJHogan
approved these changes
Aug 12, 2022
PJHogan
approved these changes
Aug 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Why Should This Be In Core?
There was a terrain tessellation implemented in previous release, but it has been not involved in camera clip distance calculation and gestures processing.
As the result camera is now rotating around the point below the surface and may render below the surface which cause graphical artifacts.
Benefits
Correct behavior of camera respecting terrain elevation.
Potential Drawbacks
None