-
Notifications
You must be signed in to change notification settings - Fork 58
Integrate parallel gdal read (write is still serial) #2018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ESMF_TYPEKIND_R4. MSL
Gdal jpe2
code. It's not a git repo inside ESMF so changes accumulate in ESMF's git but not in PIO's. MSL
Gdal jpe2
|
Jim, here's a simple question. If I make code updates and push them to the branch being merged with this PR, does the PR automatically update? or is the PR associated with a specific commit? |
|
@msl3v The PR automatically updates when you push to the PR branch. |
|
I suggest that you merge in the latest main to clear the out-of-date message. |
|
Hey @jedwards4b. This exact thing prompted my question. I HAVE updated, committed and pushed. But the PR didn't seem to update the log. If you look at the commit log for the actual branch in my repo, it's not the same as the one shown here in the PR. It may be worth mentioning this: You prob know that ESMF doesn't keep PIO as a sub-repository. It's a frozen version that is copied into the ESMF source tree. That's where I do my development. And then have to wholesale copy my changes into an actual git-enabled version of PIO. I'd tried to make PIO a sub-repository in ESMF but it broke all sorts of things in the workflow. Maybe this can be remedied, but I don't know how to do it and it's not my call. |
This PR is an update to a previous (closed) PR. This version of the code properly reads shapefile and features in parallel. It can write attributes to an existing shapefile (serial only) but cannot write the new shapefile.