Skip to content

Use anyOf instead of oneOf#547

Merged
edeutsch merged 1 commit into2.0from
fix-oneof
Feb 19, 2026
Merged

Use anyOf instead of oneOf#547
edeutsch merged 1 commit into2.0from
fix-oneof

Conversation

@tokebe
Copy link

@tokebe tokebe commented Feb 19, 2026

Fix proposed by @colleenXu in 2026-02-19 meeting

Fix proposed by @colleenXu in 2026-02-19 meeting
@uhbrar uhbrar self-requested a review February 19, 2026 20:21
@edeutsch edeutsch merged commit 7168067 into 2.0 Feb 19, 2026
2 checks passed
@colleenXu
Copy link
Contributor

colleenXu commented Feb 19, 2026

How I uncovered the issue:

The validation fails because having both edge_bindings and path_bindings fulfills >1 of the oneOf "required" sub-schemas.


For solutions:

  • only removing line 718 (required: [edge_bindings, path_bindings]) was not sufficient.
  • changing to anyOf does what we want:
    • fulfilling >1 "required" sub-schema is now fine (having both types of bindings)
    • don't need line 718

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants