Skip to content

[IOPS-3679] Updated constraint profiles#218

Open
omarisgreat wants to merge 9 commits intomainfrom
Feature-IOPS-3679-Constraint-Profiles
Open

[IOPS-3679] Updated constraint profiles#218
omarisgreat wants to merge 9 commits intomainfrom
Feature-IOPS-3679-Constraint-Profiles

Conversation

@omarisgreat
Copy link
Copy Markdown
Contributor

No description provided.

@omarisgreat
Copy link
Copy Markdown
Contributor Author

@KazeemHamzat, would you be able to check the StructureDefinitions in Forge? The branch is failing validation but I expect this is due to the number of dependencies rather than the files themselves as they are just timing out

@omarisgreat
Copy link
Copy Markdown
Contributor Author

@KazeemHamzat, Validation issues fixed

Removed SD from file names to conform to guidance
Copy link
Copy Markdown
Collaborator

@KazeemHamzat KazeemHamzat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Is the use of 'targetProfile' returned or just used in some required places?
  2. Only Genomics profiles and base HL7 are listed on some profile with UKCore. as base definition. Not a problem as we not recommending stating conformance in meta.profile. Hopefully, no one will mistakenly reference UKCore profile.
  3. Something to do later for conformance to Dev. guidance and consistency: Updating Metadata to align with Dev. guidance

@omarisgreat
Copy link
Copy Markdown
Contributor Author

@KazeemHamzat, I've updated the profiles to match the metadata guidance.

Regarding targetProfile, for these I've just added references to key profiles resources should conform to but I haven't removed the inherited profiles so these constraints are for information only at this point.

I've updated the CapabilityStatements to confirm which profiles resources should validate against so there should not be an issue with regards to declared meta.profile elements, as the implementation will only use the capability statement for validation

Hopefully this answers your comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants