Chore: [ELI-751] - Error handling#227
Merged
adam-wallernhs1 merged 17 commits intomainfrom Mar 31, 2026
Merged
Conversation
# Conflicts: # utils/data_helper.py
feyisayo-afolabi-nhs
had a problem deploying
to
dev
GitHub Actions
Failure
Contributor
|
This branch is work on a ticket in an NHS England JIRA Project. Here is a handy link to the ticket: |
feyisayo-afolabi-nhs
temporarily deployed
to
dev
GitHub Actions
Inactive
feyisayo-afolabi-nhs
temporarily deployed
to
dev
GitHub Actions
Inactive
feyisayo-afolabi-nhs
temporarily deployed
to
dev
GitHub Actions
Inactive
TOEL2
reviewed
Mar 31, 2026
TOEL2
reviewed
Mar 31, 2026
TOEL2
reviewed
Mar 31, 2026
TOEL2
reviewed
Mar 31, 2026
TOEL2
reviewed
Mar 31, 2026
Contributor
|
Looks good overall, I like the refactoring of the data helper, makes it more modular, some of those functions were a bit chunky. I've made some suggestions but as this repo belongs more to testers I'll leave that to your discretion. You'll need to do some minor refactoring after pulling in main FYI. |
# Conflicts: # utils/data_helper.py
feyisayo-afolabi-nhs
temporarily deployed
to
dev
GitHub Actions
Inactive
feyisayo-afolabi-nhs
temporarily deployed
to
dev
GitHub Actions
Inactive
feyisayo-afolabi-nhs
temporarily deployed
to
dev
GitHub Actions
Inactive
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary