VED-1017: Generate JSON ACK file#1168
Merged
JamesW1-NHS merged 49 commits intomasterfrom Feb 10, 2026
Merged
Conversation
Contributor
|
This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket: VED-1017 |
dlzhry2nhs
previously approved these changes
Feb 9, 2026
|
dlzhry2nhs
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
PR #1177 with the e2e_automation test changes merged manually. This one (not #1177) is to be merged to master.
The PRs are identical, except that #1168 has no unverified commits.
For confidence, you can verify that the branches are identical by fetching them locally and doing a diff i.e.
git fetch origin
git diff VED-1017-test-merge-e2e VED-1017-json-ack-file
Acceptance Criteria
A structured JSON ACK is generated when batch processing completes (EOF received / completion confirmed).
The ACK includes:
Conforms to the Design document: https://nhsd-confluence.digital.nhs.uk/pages/viewpage.action?pageId=1187373499&spaceKey=Vacc&title=Immunisation%2BFHIR%2BAPI%2B-%2BACK%2BFile%2BManagement#addcomment
Note: I have marked this as a breaking change as it requires changes to the E2E Automation Tests. These are ongoing. This currently builds successfully in master because the tests requiring modification have been temporarily patched.
Note to Testers
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.