Skip to content

[PRMP-1282] Add handling for unknown NHS number in review navigation#1015

Merged
lillie-dae merged 10 commits intomainfrom
PRMP-1282
Feb 9, 2026
Merged

[PRMP-1282] Add handling for unknown NHS number in review navigation#1015
lillie-dae merged 10 commits intomainfrom
PRMP-1282

Conversation

@lillie-dae
Copy link
Contributor

@lillie-dae lillie-dae commented Jan 23, 2026 •
edited by adamwhitingnhs
Loading

Overview

Jira ticket: PRMP-1282

Description

Context

Checklist

Tasks for all changes:

  • 1. I have linked this PR to its Jira ticket.
  • 2. I have run git pre-commits. (WIP)
  • 3. I have added and/or updated relevant tests.
  • 4. I have updated relevant documentation.
  • 5. I have considered the cross-team impact (and have PR approval from both Core & Demographics if necessary).
  • 6. I have successfully deployed this change to a sandbox and witnessed unit and e2e tests passing:

Additional tasks for UI changes (delete if not applicable):

  • 1. I have run the UI Smoke Tests against the deployed sandbox and witnessed it passing:
  • 2. I have added evidence (to this PR) e.g. screenshots/gifs of all visual changes.

@NogaNHS NogaNHS changed the title [PRMP-1282] Add handling for unknown NHS number in review navigation … [PRMP-1282] Add handling for unknown NHS number in review navigation Jan 26, 2026
@lillie-dae lillie-dae marked this pull request as ready for review January 26, 2026 12:44
@lillie-dae lillie-dae requested review from a team as code owners January 26, 2026 12:44
NogaNHS
NogaNHS previously approved these changes Jan 26, 2026
View reviewed changes
@lillie-dae lillie-dae dismissed stale reviews from steph-torres-nhs and NogaNHS via b8956a2 January 30, 2026 08:57
adamwhitingnhs
adamwhitingnhs previously approved these changes Feb 2, 2026
View reviewed changes
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Code security issues found

View full details here.

@github-actions
Copy link

github-actions bot commented Feb 9, 2026

Code security issues found

View full details here.

@github-actions
Copy link

github-actions bot commented Feb 9, 2026

Code security issues found

View full details here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 9, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@lillie-dae lillie-dae enabled auto-merge (squash) February 9, 2026 10:53
@lillie-dae lillie-dae merged commit db93cda into main Feb 9, 2026
19 of 20 checks passed
@lillie-dae lillie-dae deleted the PRMP-1282 branch February 9, 2026 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NogaNHS NogaNHS NogaNHS approved these changes

@adamwhitingnhs adamwhitingnhs adamwhitingnhs approved these changes

@steph-torres-nhs steph-torres-nhs steph-torres-nhs left review comments

@AndyFlintAnswerDigital AndyFlintAnswerDigital Awaiting requested review from AndyFlintAnswerDigital AndyFlintAnswerDigital is a code owner automatically assigned from NHSDigital/access-store

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lillie-dae @NogaNHS @steph-torres-nhs @adamwhitingnhs @bethany-kish-nhs