Skip to content

[PRMP-1373] Fix reviews routing #1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adamwhitingnhs wants to merge 6 commits into
base: main
Choose a base branch
from
+1,232 −1,509

Merge branch 'main' into PRMP-1373

8605218
Select commit
Loading
Failed to load commit list.
Open

[PRMP-1373] Fix reviews routing #1141

Merge branch 'main' into PRMP-1373
8605218
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Mar 6, 2026 in 1m 1s

Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 100 in app/src/components/blocks/_reviews/reviewDetailsDocumentUploadingStage/ReviewDetailsDocumentUploadingStage.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since it does not change the type of the expression. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_national-document-repository&issues=AZyvasnwZnNQZknkFoXq&open=AZyvasnwZnNQZknkFoXq&pullRequest=1141

Check warning on line 105 in app/src/components/blocks/_reviews/reviewDetailsDocumentUploadingStage/ReviewDetailsDocumentUploadingStage.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since it does not change the type of the expression. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_national-document-repository&issues=AZyvasnwZnNQZknkFoXr&open=AZyvasnwZnNQZknkFoXr&pullRequest=1141

Check warning on line 88 in app/src/components/blocks/_reviews/reviewDetailsDocumentSelectStage/ReviewDetailsDocumentSelectStage.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since it does not change the type of the expression. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_national-document-repository&issues=AZyvashkZnNQZknkFoXm&open=AZyvashkZnNQZknkFoXm&pullRequest=1141

Check warning on line 295 in app/src/components/blocks/_reviews/reviewDetailsDocumentUploadingStage/ReviewDetailsDocumentUploadingStage.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since it does not change the type of the expression. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_national-document-repository&issues=AZyvasnwZnNQZknkFoXs&open=AZyvasnwZnNQZknkFoXs&pullRequest=1141

Check warning on line 88 in app/src/components/blocks/_reviews/reviewDetailsDocumentSelectStage/ReviewDetailsDocumentSelectStage.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since it does not change the type of the expression. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_national-document-repository&issues=AZyvashkZnNQZknkFoXn&open=AZyvashkZnNQZknkFoXn&pullRequest=1141
View more details on SonarQubeCloud