CCM-13697: Letters Key and Source Data Item#323
Merged
masl2 merged 4 commits intofeature/CCM-12997from Dec 24, 2025
Merged
Conversation
francisco-videira-nhs
added a commit
that referenced
this pull request
Jan 13, 2026
* Add upsert lambda * Fix names * Fix unit test * Fix unit test dates * Fix lambda handler name export * Add event-schemas-letter-rendering * Add GitHub NPM registry configuration to .npmrc * Add version check and Node.js setup to CI workflow * TO REVERT AFTER TEST: conditional check for event schema version update * Refactor event schema version checks in CI workflow * Add GitHub NPM registry URL to Node.js setup in workflows * Log npm response * Add NODE_AUTH_TOKEN to GitHub Actions environment for NPM access * Revert "Add GitHub NPM registry URL to Node.js setup in workflows" This reverts commit f1444fd. * Move NODE_AUTH_TOKEN to npm view step in CI workflow * Reapply "Add GitHub NPM registry URL to Node.js setup in workflows" This reverts commit 5741a86. * Add NODE_AUTH_TOKEN to NPM install steps in workflows * Re-enable conditional check on published package check * Add NODE_AUTH_TOKEN input for GitHub package registry access in workflows * Add packages:read to permissions * delete old test * fix trivy scan step * Fix gh pkg registry test stage * fix local npmrc * Fix unit test timestamps, add source * Add notification parsing logic * fix tf var * Fix ddb permissions * Add latest version event schema letter rendering * Add trying v1 parse if v2 fails * Add subject * Split upsert operations * Letter variant map to vars * Revert supplierStatusSk * Fix dependencies * CCM-13697: Letters Key and Source Data Item (#323) * swap partition and sort for letters * store changes and source, subject, billingref * unsafe marker * rename correctly * missing close brace * minor refactor upsert unit tests * remove dup line * gitleaksignore * bump package version * Fix get API for component tests --------- Co-authored-by: Mike Houston <michael.houston4@nhs.net> Co-authored-by: Mike Houston <60653100+m-houston@users.noreply.github.com> Co-authored-by: Mark Slowey <113013138+masl2@users.noreply.github.com> Co-authored-by: Mark Slowey <mark.slowey1@nhs.net> Co-authored-by: Steve Buxton <steve.buxton@nhs.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change the Letter store to use letter ID as it's primary partition key
Source, Subject and (new) BillingRef are stored and placed in outbound events
Branched from #280 as an enhancement
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.