Skip to content

Fix grid dimension overflow in fused Butina neighbor count kernel#194

Merged
scal444 merged 3 commits into
NVIDIA-BioNeMo:mainfrom
scal444:fix-butina-grid-overflow
Jun 8, 2026
Merged

Fix grid dimension overflow in fused Butina neighbor count kernel#194
scal444 merged 3 commits into
NVIDIA-BioNeMo:mainfrom
scal444:fix-butina-grid-overflow

Conversation

@scal444

@scal444 scal444 commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Giant clustering tasks were hitting signed int overflow, moved to a 2D grid to expand limits by 5 OOM

@scal444 scal444 requested a review from moradza June 3, 2026 12:16

@moradza moradza left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scal444

scal444 commented Jun 6, 2026

Copy link
Copy Markdown
Collaborator Author

Fixes #199

@scal444 scal444 requested a review from evasnow1992 June 7, 2026 11:42

@evasnow1992 evasnow1992 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this. Changes look good to me.

@scal444 scal444 merged commit b19bf4f into NVIDIA-BioNeMo:main Jun 8, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants