[codex] Fix NEST SSL model-support training batches#15812
Merged
Conversation
Collaborator
Author
|
/ok to test 4e587ac |
Contributor
|
[🤖]: Hi @pzelasko 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully. So it might be time to merge this PR or get some approvals. |
chtruong814
previously approved these changes
Jun 19, 2026
Collaborator
|
/ok to test acd5347 |
chtruong814
added
the
r3.0.0
Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>
Signed-off-by: Piotr Żelasko <pzelasko@nvidia.com>
pzelasko
force-pushed
the
codex/fix-15810-nest-ssl-training-step
branch
from
05870fe to
659dbba
Compare
Contributor
|
[🤖]: Hi @pzelasko 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully. So it might be time to merge this PR or get some approvals. |
…ssl-training-step Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Collaborator
|
/ok to test a088d44 |
chtruong814
approved these changes
Jun 23, 2026
Contributor
|
[🤖]: Hi @pzelasko 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully. So it might be time to merge this PR or get some approvals. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AudioNoiseBatch.audioandnoisetensors sonoisy_audiomatches the SSL dataset contract:audio + noise.Root Cause
The generated training-step tests created independent random
audio,noise, andnoisy_audiotensors. That does not match the synthetic batch shape produced by the SSL datasets and can produce non-finite loss for the restored NEST SSL artifacts.Validation
isort --check tests/e2e_nightly/test_model_support_nvidia__ssl_en_nest_large_v1_0.py tests/e2e_nightly/test_model_support_nvidia__ssl_en_nest_xlarge_v1_0.pyblack --check tests/e2e_nightly/test_model_support_nvidia__ssl_en_nest_large_v1_0.py tests/e2e_nightly/test_model_support_nvidia__ssl_en_nest_xlarge_v1_0.pypytest tests/e2e_nightly/test_model_support_nvidia__ssl_en_nest_large_v1_0.py tests/e2e_nightly/test_model_support_nvidia__ssl_en_nest_xlarge_v1_0.py --collect-only -qFull NEST artifact execution was not run locally because the required
.nemofiles are not present under/home/TestData/nemo-speech-ci-models.Fixes #15810