fix(libsy): run should return when stream ends#124
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Walkthrough
ChangesAlgorithm execution
Estimated code review effort: 4 (Complex) | ~45 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
455d0da to
73aeac2
Compare
Signed-off-by: Greg Clark <grclark@nvidia.com>
73aeac2 to
2cceb60
Compare
What
Algorithm::runshould return when the stream has a final result canceling any in_flightCallLlmfutures.Before this MR
runwould continue running until all the futures were done even after the final result.Also simplified the logic a bit and remove the arbitrary in flight cap. (no thanks to claude)
Why
How tested
uv run ruff check .cleanuv run mypy switchyardcleanuv run pytest tests/greenChecklist
snake_caseof the primary class.switchyard/__init__.py.__all__if intended for downstream use.--helpupdated if customer-facing surface changed.Signed-off-by: Your Name <email>) per the DCO.Notes for reviewers
Anything reviewers should pay extra attention to — risky paths, follow-up tickets, intentional trade-offs.
Summary by CodeRabbit